From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11700 invoked by alias); 21 Aug 2003 04:04:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11693 invoked from network); 21 Aug 2003 04:04:19 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 21 Aug 2003 04:04:19 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BAB4F2B7F; Thu, 21 Aug 2003 00:03:56 -0400 (EDT) Message-ID: <3F4444AC.6010409@redhat.com> Date: Thu, 21 Aug 2003 04:04:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Elizabeth Chastain Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com, jimb@redhat.com Subject: Re: [rfa] space reduction in gdbtypes.h References: <200308201746.h7KHkdkV009277@duracef.shout.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00355.txt.bz2 > /* FIXME, these should probably be restricted to a Fortran-specific > field in some fashion. */ > #define BOUND_CANNOT_BE_DETERMINED 5 > @@ -306,8 +306,8 @@ > #define BOUND_BY_REF_IN_REG 2 > #define BOUND_BY_VALUE_IN_REG 1 > #define BOUND_SIMPLE 0 > - int upper_bound_type; > - int lower_bound_type; > + int upper_bound_type : 4; > + int lower_bound_type : 4; Hmm, doesn't this part scream ENUM? Without that the packing is unsafe: adding an extra variant that overflows the field won't be detected; compilers capable of checking enum assignments won't do anything useful. enjoy, Andrew