From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18027 invoked by alias); 18 Aug 2003 09:09:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18013 invoked from network); 18 Aug 2003 09:09:28 -0000 Received: from unknown (HELO maxipes.logix.cz) (81.0.234.97) by sources.redhat.com with SMTP; 18 Aug 2003 09:09:28 -0000 Received: from suse.cz (styx.suse.cz [213.210.157.162]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "Michal Ludvig", Issuer "Personal Freemail RSA 2000.8.30" (verified OK)) by maxipes.logix.cz (Postfix) with ESMTP id 87B23299BA; Mon, 18 Aug 2003 11:09:26 +0200 (CEST) Message-ID: <3F4097E1.6000706@suse.cz> Date: Mon, 18 Aug 2003 09:09:00 -0000 From: Michal Ludvig Organization: SuSE CR, s.r.o. User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.5b) Gecko/20030813 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: GDB Patches , Mark Kettenis Subject: Re: RFA: Actual support for tracing forks on GNU/Linux References: <20030618232942.GA982@nevyn.them.org> <20030628163444.GB9716@nevyn.them.org> <20030709215713.GA25331@nevyn.them.org> <20030724184849.GC1842@nevyn.them.org> <200308101611.h7AGBfnh058626@elgar.kettenis.dyndns.org> <20030817182245.GA24800@nevyn.them.org> In-Reply-To: <20030817182245.GA24800@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00288.txt.bz2 Daniel Jacobowitz told me that: > 2003-08-17 Daniel Jacobowitz > > * config/i386/nm-linux.h (LINUX_CHILD_POST_STARTUP_INFERIOR): > Define. > * i386-linux-nat.c: Include "linux-nat.h". > (child_post_startup_inferior): New function. > * i386-nat.c (child_post_startup_inferior): Wrap in #ifdef. > * linux-nat.c (linux_enable_event_reporting): New function. > (child_post_attach, linux_child_post_startup_inferior) > (child_post_startup_inferior, child_follow_fork) > (linux_handle_extended_wait, kill_inferior): New functions. Hi Daniel, this change broke build on AMD64. Per-se I'm getting linker error: libgdb.a(linux-nat.o)(.text+0x3e8): In function `child_post_startup_inferior': ../../gdb-6.0/gdb/linux-nat.c:223: multiple definition of `child_post_startup_inferior' libgdb.a(i386-nat.o)(.text+0x52):../../gdb-6.0/gdb/i386-nat.c:238: first defined here /usr/lib64/gcc-lib/x86_64-suse-linux/3.3/../../../../x86_64-suse-linux/bin/ld: Warning: size of symbol `child_post_startup_inferior' changed from 11 in libgdb.a(i386-nat.o) to 41 in libgdb.a(i386-nat.o) collect2: ld returned 1 exit status make: *** [gdb] Error 1 I.e. `child_post_startup_inferior' is defined twice. When I define LINUX_CHILD_POST_STARTUP_INFERIOR in config/i386/nm-x86-64linux.h I get: libgdb.a(inftarg.o)(.text+0x692): In function `init_child_ops': ../../gdb-6.0/gdb/inftarg.c:593: undefined reference to `child_post_startup_inferior' libgdb.a(lin-lwp.o)(.text+0x3f76): In function `init_lin_lwp_ops': ../../gdb-6.0/gdb/lin-lwp.c:1675: undefined reference to `child_post_startup_inferior' I.e. it's never defined. The problem seems to be that child_post_startup_inferior() in both i386-nat.c and linux-nat.c is #ifNdef-ed, i.e. either both undefined or both defined. Is that intended? However the proper fix for amd64 seems to be: Index: x86-64-linux-nat.c =================================================================== RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v retrieving revision 1.23.6.2 diff -u -p -r1.23.6.2 x86-64-linux-nat.c --- x86-64-linux-nat.c 17 Jul 2003 12:51:55 -0000 1.23.6.2 +++ x86-64-linux-nat.c 18 Aug 2003 09:05:51 -0000 @@ -347,3 +347,9 @@ ps_get_thread_area (const struct ps_proc return PS_ERR; /* ptrace failed. */ } +void +child_post_startup_inferior (ptid_t ptid) +{ + i386_cleanup_dregs (); + linux_child_post_startup_inferior (ptid); +} Right? OK to apply? Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * (+420) 296.545.373 * http://www.suse.cz