From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9382 invoked by alias); 16 Aug 2003 19:32:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9352 invoked from network); 16 Aug 2003 19:32:47 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 16 Aug 2003 19:32:47 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6F4922B7F; Sat, 16 Aug 2003 15:32:31 -0400 (EDT) Message-ID: <3F3E86CF.8030605@redhat.com> Date: Sat, 16 Aug 2003 19:32:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [patch, rfa:doco, rfa:ppc] Generic red zone arch method References: <3F3E80F0.2070607@redhat.com> <20030816191538.GA5883@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00264.txt.bz2 > On Sat, Aug 16, 2003 at 03:07:28PM -0400, Andrew Cagney wrote: > >> Hello, >> >> Ref: Skip the "red zone" on AMD64 >> http://sources.redhat.com/ml/gdb-patches/2003-08/msg00092.html >> >> The attached implements the suggested fix in that thread. For x86-64, >> it gives the same results as the original change (need more test cases). >> >> Eli, doco ok? >> >> Kevin, for PPC64 and AIX I pulled the numbers from ABI doco. It isn't >> yet tested. For PPC64 I've too many other failures for results to be >> meaningful, and for AIX probably won't happen :-(. >> >> The remaining bits (framework and x86-64) I'll commit in a few days. >> Andrew > > > I'm sure there's a reason this won't work but... is gdbarch_frame_align > called from anywhere else, i.e. that should not include the red zone? > Why isn't skipping the red zone there sufficient? Please look in infcall.c at how frame_align is used :-/ Andrew