From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25833 invoked by alias); 7 Aug 2003 04:17:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25817 invoked from network); 7 Aug 2003 04:17:27 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 7 Aug 2003 04:17:27 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9517C2B7F; Thu, 7 Aug 2003 00:17:24 -0400 (EDT) Message-ID: <3F31D2D4.4070807@redhat.com> Date: Thu, 07 Aug 2003 04:17:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Kei Sakamoto , gdb-patches@sources.redhat.com Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error References: <028801c35a51$47db96d0$5169910a@KEI> <20030805180235.GA30002@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00085.txt.bz2 > On Mon, Aug 04, 2003 at 03:26:03PM +0900, Kei Sakamoto wrote: > >> Thank you, everyone. Now m32r is back! :-) >> >> The attached fixes compile errors of asm-source.exp for m32r-elf. >> There are several missing symbols. >> >> It also replaces ld24 instruction with seth/add3 instruction. >> ld24 can handle only 24bit address, so ld24 fails to set sp when >> _stack is located at a large address. >> >> Kei Sakamoto >> >> === >> >> 2003-08-04 Kei Sakamoto >> >> * gdb.asm/m32r.inc : Add several missing symbols. Replace ld24 >> with seth/add3. > > > Two minor things: > - You accidentally sent a reversed diff. > - ChangeLog formatting. It should be: > > 2003-08-04 Kei Sakamoto > > * gdb.asm/m32r.inc: Add several missing symbols. Replace ld24 > with seth/add3. > > One less minor thing: no other port needs to declare symbols. It looks > like part of libc is being dragged in somehow on m32r; could you > explain why the symbols are necessary? This, I suspect is a hangover from an historic foobar that no ones gone back to fix. The original assembler tests used AS and LD making for a very raw test framework. It was an intentional decision, very like the simulator tests, rely on an absolute minimum to get things working. Unfortunatly, sometime back a change switched LD to GCC but at the time no one realised (or those reviewing remembered gdb.asm's intent). Anyway, it needs to be switched back and that isn't going to be pleasant ... Andrew