From: "J. Johnston" <jjohnstn@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: modernization of ia64-tdep.c with new frame model for gdb-6.0 branch
Date: Thu, 31 Jul 2003 21:39:00 -0000 [thread overview]
Message-ID: <3F298C9E.9060700@redhat.com> (raw)
In-Reply-To: <20030731192002.GA16977@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Thu, Jul 31, 2003 at 03:03:37PM -0400, J. Johnston wrote:
>
>>I found the fix for making this patch work on the mainline as well. It
>>turns out that Daniel J.'s patch that verifies that the pc and function
>>address are in the same section trips up for the ia64 printf calls.
>>I had added a check in examine_prologue which caught this problem and
>>recognized that the cfm didn't match up so we should treat the function
>>as frameless. The fix is simply to set the cache frameless
>>flag on by default. This corresponds to the new examine_prologue()
>>logic which assumes frameless until proven otherwise. Now, when
>>frame_func_unwind()
>>returns 0 when it finds the pc and the function it is supposed to be in
>>are in different sections, the cache will be marked frameless and I will
>>correctly look at current register values rather than depend on the cache.
>>
>>I have resubmitted the patch including the one line change.
>
>
> Hrm, why is that triggering for printf? Is it correct, or are we
> stopped in some trampoline?
>
The printf function gets called indirectly.
Your code is doing the right thing. Before your change, gdb was reporting that the
indirect code was inside _init which wasn't true. My new code was ok with this because
it handled it by noticing the cfm register was not set correctly. With the change, the func addr
is now coming back as 0 and my old code failed to treat this as a frameless function.
This ended up causing an error setting a breakpoint at 0 when performing a next over a
printf call.
-- Jeff J.
next prev parent reply other threads:[~2003-07-31 21:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-30 20:54 J. Johnston
2003-07-31 19:03 ` J. Johnston
2003-07-31 19:20 ` Daniel Jacobowitz
2003-07-31 21:39 ` J. Johnston [this message]
2003-08-08 17:32 ` J. Johnston
2003-08-22 21:46 ` Kevin Buettner
2003-08-25 18:12 ` J. Johnston
2003-08-25 18:41 ` Kevin Buettner
2003-08-25 23:29 ` J. Johnston
2003-08-08 17:49 Michael Elizabeth Chastain
2003-08-08 18:57 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F298C9E.9060700@redhat.com \
--to=jjohnstn@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox