From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29019 invoked by alias); 29 Jul 2003 21:19:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28984 invoked from network); 29 Jul 2003 21:19:48 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 29 Jul 2003 21:19:48 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h6TLJkZ09089 for ; Tue, 29 Jul 2003 17:19:46 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h6TLJj617323; Tue, 29 Jul 2003 17:19:45 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h6TLJiK28450; Tue, 29 Jul 2003 14:19:44 -0700 Message-ID: <3F26E4F0.2070506@redhat.com> Date: Tue, 29 Jul 2003 21:19:00 -0000 From: Michael Snyder User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni CC: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: tls test maintainer, was Re: [rfa/testsuite] gdb.threads/tls.{exp,c} fixes References: <200307292044.h6TKiqKF016861@duracef.shout.net> <16166.58698.342251.249709@localhost.redhat.com> In-Reply-To: <16166.58698.342251.249709@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00525.txt.bz2 Elena Zannoni wrote: >Michael Elizabeth Chastain writes: > > This patch fixes all the ERRORs that I see with > > native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5-rh. > > All the results are now PASS, FAIL, KFAIL, and UNSUPPORTED. > > > > The tls.exp change is a one-liner to initialize a variable > > in all cases (not just the PASS case). > > > > The tls.c change is the calls to sem_wait. The current code > > calls sem_wait and then tests errno. My code calls sem_wait > > and tests errno only if sem_wait failed. This is important, > > because I have observed a lot of test suite hangs caused by > > return_value = 0, errno = EINTR (happens about 75% to 90% of > > the time in my test bed). > > > > Tested on native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5-rh, > > with a variety of gcc's and binutils. > > > >thanks, seems to work for me too. > >elena > BTW, although this test is in the gdb.threads directory, of which I'm listed as the maintainer of record, I'd like to recognize Elena as the de facto maintainer of this test. ;-)