From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 504 invoked by alias); 28 Jul 2003 10:17:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 491 invoked from network); 28 Jul 2003 10:17:47 -0000 Received: from unknown (HELO kymera.ipitec.it) (217.59.47.82) by sources.redhat.com with SMTP; 28 Jul 2003 10:17:47 -0000 Received: from ipitec.it (pcmikelo.ipitec.it [172.16.1.19]) by kymera.ipitec.it (Postfix) with ESMTP id 9618F7E32; Mon, 28 Jul 2003 12:14:53 +0200 (CEST) Message-ID: <3F24F903.5080308@ipitec.it> Date: Mon, 28 Jul 2003 10:17:00 -0000 From: Andrea Michelotti Reply-To: amichelotti@ipitec.it User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020830 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Andrew Cagney , gdb-patches@sources.redhat.com, Michael Snyder Subject: Re: patch for info threads problem with target arm-elf (PR 1199). References: <3F200D12.6000103@ipitec.it> <3F21CAA4.30400@redhat.com> <20030726002921.GA5573@nevyn.them.org> <3F21D8BE.8050401@redhat.com> <20030726014845.GA18738@nevyn.them.org> <3F21E320.4090007@redhat.com> <20030726021548.GA22833@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00491.txt.bz2 Daniel Jacobowitz wrote: >On Fri, Jul 25, 2003 at 10:10:40PM -0400, Andrew Cagney wrote: > > >>>- /* Avoid coredumps which would happen if we tried to access a NULL >>>- deprecated_selected_frame. */ >>>- if (!target_has_stack) >>>- error ("No stack."); >>>+ /* Check that there really is a frame. This happens when a simulator >>>+ is connected but not loaded or running, for instance. */ >>>+ if (saved_frame_level < 0) >>>+ error ("No frame."); >>> >>> >>This would only happen to old architectures (legacy_get_prev_frame). >>With new architectures (get_prev_frame), frame creation is so lazy that >>an inner most frame is (hopefully?) always created. Can you make this >>check conditional on legacy_frame_p? >> >> > >Ah, that's the bit I was missing. Thanks, sounds reasonable to me. > > > I've tried the patch, it's ok. thanks. ciao Andrea. -------------------------------------- Andrea Michelotti HW/SW Co-Design Manager IPITEC (ATMEL)