From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31450 invoked by alias); 27 Jul 2003 16:24:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31440 invoked from network); 27 Jul 2003 16:24:47 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 27 Jul 2003 16:24:47 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BFD922B7F; Sun, 27 Jul 2003 12:24:41 -0400 (EDT) Message-ID: <3F23FCC9.9040908@redhat.com> Date: Sun, 27 Jul 2003 16:24:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] revised m32r target References: <007701c341d0$5d44aa50$5169910a@KEI> <02ec01c3477c$8ddf3c00$5169910a@KEI> <3F1C35C6.4010603@redhat.com> <01fc01c3500e$7800d2f0$5169910a@KEI> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00471.txt.bz2 > Kei, >> >> I've checked in the .c files, as posted. Not bad, not bad at all. >> Can you just see how many of the attached can also be fixed? I'll then >> look at enabling it and pulling it into the 6 branch. >> >> Andrew > > > Thank you for checking in. I revised m32r-tdep.c and m32r-rom.c. > I think all warnings in your e-mail are fixed now. I attached the > patch file. > > By the way, would you tell me how to get these warning messages? I ran the script: "gdb_ari.sh -Wari ". See: http://sources.redhat.com/gdb/current/ari/ http://sources.redhat.com/gdb/current/ari/gdb_ari.sh > I built gdb with --enable-build-warnings, but gcc didn't show them. Can you try configuring/building with: --enable-gdb-build-warnings=,-Werror (all targets should configure/build with that) I'm seeing the warnings: m32r-tdep.c: In function `m32r_store_return_value': m32r-tdep.c:289: warning: pointer of type `void *' used in arithmetic m32r-rom.c: In function `m32r_upload_command': m32r-rom.c:466: warning: `hostent' might be used uninitialized in this function Can you please try to reproduce / fix this. BTW, for the ChangeLog I checked in: 2003-07-27 Andrew Cagney Patch from 2003-07-22 Kei Sakamoto : * m32r-tdep.c (m32r_memory_insert_breakpoint): Fix code style - operator at start and not end of line. (decode_prologue): Ditto. (m32r_frame_unwind_cache, m32r_unwind_sp, m32r_unwind_pc): Use frame_unwind_register_unsigned instead of frame_unwind_unsigned_register. (m32r_read_pc): Use regcache_cooked_read_unsigned instead of read_register. (m32r_push_dummy_call): Use register_size instead of REGISTER_RAW_SIZE. (m32r_frame_sniffer): Replace m32r_frame_p. (m32r_gdbarch_init): Call frame_unwind_append_sniffer. * m32r-rom.c (report_transfer_performance): Delete extern declaration. (m32r_load, m32r_upload_command): Use print_transfer_performance instead of report_transfer_performance. (_initialize_m32r_rom): Use add_setshow_cmd instead of add_set_cmd / add_show_from_set. as it better states what was changed. Andrew