From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27883 invoked by alias); 24 Jul 2003 06:27:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27876 invoked from network); 24 Jul 2003 06:27:51 -0000 Received: from unknown (HELO maxipes.logix.cz) (81.0.234.97) by sources.redhat.com with SMTP; 24 Jul 2003 06:27:51 -0000 Received: from suse.cz (styx.suse.cz [213.210.157.162]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "Michal Ludvig", Issuer "Personal Freemail RSA 2000.8.30" (verified OK)) by maxipes.logix.cz (Postfix) with ESMTP id 8BB6B299DF; Thu, 24 Jul 2003 08:27:44 +0200 (CEST) Message-ID: <3F1F7C61.2070903@suse.cz> Date: Thu, 24 Jul 2003 06:27:00 -0000 From: Michal Ludvig Organization: SuSE CR, s.r.o. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030610 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Elena Zannoni Cc: GDB Patches Subject: Re: [RFA] Avoid segfault in decode_line_2 References: <3F0E61E7.5020900@suse.cz> <16151.62826.629842.506716@localhost.redhat.com> <16158.58830.541858.789928@localhost.redhat.com> In-Reply-To: <16158.58830.541858.789928@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00428.txt.bz2 Elena Zannoni told me that: > Elena Zannoni writes: > > Michal Ludvig writes: > > > Hi all, > > > this patch fixes a problem that I met while debugging a testsuite > > > failure on amd64: > > > > Yes, but, could you change this to use an if (values.sals[i].symtab) > > before the printf_filtered and avoid the conditional expression? You > > will end up getting rid of the if() for the No symtab?.. case as well, > > since that can be folded into a single printf. > > > > elena > > > I checked in the following: > > 2003-07-23 Michal Ludvig > Elena Zannoni > > * linespec.c (decode_line_2): Avoid crash if > find_function_start_sal() returns empty record. Thanks! (And sorry, I forgot to do it... :-) Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * (+420) 296.545.373 * http://www.suse.cz