From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8803 invoked by alias); 21 Jul 2003 18:22:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8796 invoked from network); 21 Jul 2003 18:22:40 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 21 Jul 2003 18:22:40 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 580532B7F; Mon, 21 Jul 2003 14:22:34 -0400 (EDT) Message-ID: <3F1C2F6A.30607@redhat.com> Date: Mon, 21 Jul 2003 18:22:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com, jimb@redhat.com, fedor@doc.com Subject: Re: RFA symtab: Fix for PR c++/1267 ("next" and shared libraries) References: <20030719181817.GA11670@nevyn.them.org> <3F1C1254.2070007@redhat.com> <20030721162750.GA6754@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00376.txt.bz2 > > No, really, I still think that the comment is wrong. The get_frame_id > call triggers the prologue analyzer to analyze the NEXT frame. I.E. > this_id is called with the NEXT frame, and THIS cache. Nope. get_frame_id triggers the analysis of THIS frame's prologue (i.e., next_frame & this_cache). > The call to frame_pc_unwind uses THIS frame and creates the PREV cache. > It's one frame off on the stack. The frame it would be saving from > prologue analysis is not the one we'd need to analyze for the > get_frame_id call. Nope. frame_pc_unwind would turn into frame_register_unwind (this, PC_REGNUM) and that will also trigger the analysis of THIS frame's prologue (i.e., next_frame & this_cache). Andrew