From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25954-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 6663 invoked by alias); 15 Jul 2003 22:34:01 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6649 invoked from network); 15 Jul 2003 22:34:00 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 15 Jul 2003 22:34:00 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h6FMY0H28149;
	Tue, 15 Jul 2003 18:34:00 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h6FMXwS23648;
	Tue, 15 Jul 2003 18:33:58 -0400
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h6FMXvK06327;
	Tue, 15 Jul 2003 15:33:57 -0700
Message-ID: <3F148155.9010602@redhat.com>
Date: Tue, 15 Jul 2003 22:34:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Elena Zannoni <ezannoni@redhat.com>
CC: gdb-patches@sources.redhat.com, ezannoni
 <ezannoni@sources.redhat.com>,
   "vinschen >> Corinna Vinschen"
 <vinschen@redhat.com>
Subject: Re: [RFA] Improvements for sh double register display
References: <3F031E03.3040206@redhat.com> <16148.21516.843971.449438@localhost.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-07/txt/msg00311.txt.bz2

Elena Zannoni wrote:
> Michael Snyder writes:
>  > 2003-07-02  Michael Snyder  <msnyder@redhat.com>
>  > 
>  > 	* sh-tdep.c (do_dr_register_info): Fix register number output
>  > 	(0, 2, 4, ... not 0, 1, 2...).  Display DP register both in
>  > 	hex and in floating point (noting when it is not valid FP).
>  > 
>  > Index: sh-tdep.c
>  > ===================================================================
>  > RCS file: /cvs/src/src/gdb/sh-tdep.c,v
>  > retrieving revision 1.132
>  > diff -p -r1.132 sh-tdep.c
>  > *** sh-tdep.c	13 Jun 2003 04:40:34 -0000	1.132
>  > --- sh-tdep.c	2 Jul 2003 18:00:22 -0000
>  > *************** static void
>  > *** 3928,3938 ****
>  >   do_dr_register_info (int dr_regnum)
>  >   {
>  >     int first_fp_reg_num = dr_reg_base_num (dr_regnum);
>  >   
>  > !   printf_filtered ("dr%d\t0x%08x%08x\n", 
>  > ! 		    dr_regnum - gdbarch_tdep (current_gdbarch)->DR0_REGNUM, 
>  > ! 		    (int) read_register (first_fp_reg_num),
>  > ! 		    (int) read_register (first_fp_reg_num + 1));
>  >   }
>  >   
>  >   /* Double precision registers, compact mode. */
>  > --- 3928,3962 ----
>  >   do_dr_register_info (int dr_regnum)
>  >   {
>  >     int first_fp_reg_num = dr_reg_base_num (dr_regnum);
>  > +   char *raw_buffer;
>  > +   double dbl;
>  > +   int inv;
>  >   
>  > !   /* Allocate space for the float. */
>  > !   raw_buffer = (char *) alloca (2 * REGISTER_RAW_SIZE (FP0_REGNUM));
> 
> Can you use something other than alloca here? Also, this will collide
> in mid air with Corinna's revamp. Maybe you can revisit this after she
> is done? Otherwise it's ok.

OK, I'll touch space-helmets with Corinna.
BTW, what's wrong with alloca?