From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10390 invoked by alias); 15 Jul 2003 15:51:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10374 invoked from network); 15 Jul 2003 15:51:23 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 15 Jul 2003 15:51:23 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 481E72B79 for ; Tue, 15 Jul 2003 11:51:22 -0400 (EDT) Message-ID: <3F1422FA.3040700@redhat.com> Date: Tue, 15 Jul 2003 15:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [patch:rfc, rfa:doco] Add -Wformat-nonliteral to -Werror list Content-Type: multipart/mixed; boundary="------------090401040306070203080500" X-SW-Source: 2003-07/txt/msg00283.txt.bz2 This is a multi-part message in MIME format. --------------090401040306070203080500 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 189 Hello, This adds the GCC -Werror option -Wformat-nonliteral to GDB's compiler warning list. Fixing this one turned out to be easy. I'll look to commit in a week, Eli, the doco? Andrew --------------090401040306070203080500 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1726 2003-07-15 Andrew Cagney * configure.in (build_warnings): Add -Wformat-nonliteral. * configure: Re-generate. Index: doc/ChangeLog 2003-07-15 Andrew Cagney * gdbint.texinfo (Coding): Add -Wformat-nonliteral to -Werror list. Index: configure.in =================================================================== RCS file: /cvs/src/src/gdb/configure.in,v retrieving revision 1.128 diff -u -r1.128 configure.in --- configure.in 8 Jun 2003 18:27:13 -0000 1.128 +++ configure.in 15 Jul 2003 15:47:37 -0000 @@ -976,7 +976,7 @@ # NOTE: If you add to this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ --Wformat -Wparentheses -Wpointer-arith -Wuninitialized" +-Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Wformat-nonliteral" # Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs # -Wunused-function -Wunused-label -Wunused-variable -Wunused-value # -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual Index: doc/gdbint.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.155 diff -u -r1.155 gdbint.texinfo --- doc/gdbint.texinfo 22 Jun 2003 04:28:04 -0000 1.155 +++ doc/gdbint.texinfo 15 Jul 2003 15:47:41 -0000 @@ -5009,8 +5009,9 @@ @item -Wtrigraphs @item -Wformat +@itemx -Wformat-nonliteral Since @value{GDBN} uses the @code{format printf} attribute on all -@code{printf} like functions this checks not just @code{printf} calls +@code{printf} like functions these check not just @code{printf} calls but also calls to functions such as @code{fprintf_unfiltered}. @item -Wparentheses --------------090401040306070203080500--