From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25871-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25730 invoked by alias); 10 Jul 2003 23:22:28 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25718 invoked from network); 10 Jul 2003 23:22:26 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 10 Jul 2003 23:22:26 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 9A6FE2B6E; Thu, 10 Jul 2003 19:22:26 -0400 (EDT)
Message-ID: <3F0DF532.90801@redhat.com>
Date: Thu, 10 Jul 2003 23:22:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Theodore A. Roth" <troth@openavr.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Simplify gdbarch.sh a tiny bit
References: <3F0DE1F3.2010401@redhat.com> <Pine.LNX.4.53.0307101610020.24809@knuth.amplepower.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-07/txt/msg00228.txt.bz2

> On Thu, 10 Jul 2003, Andrew Cagney wrote:
> 
> 
>> Hello,
>>
>> The attached simplfies gdbarch.sh a tiny bit - it uses gdb_assert
>> instead of internal_error in a few places (from memory gdbarch.sh was
>> written before gdb_assert was added).
> 
> 
> I'm getting a build failure now:

Oh, flip.  The bit to revert should be obvious.  I'm off line for a few 
hours.

Andrew


> gcc -c -g -O2    -I. -I../../gdb -I../../gdb/config
> -DLOCALEDIR="\"/home/roth/local/avr/share/locale\"" -DHAVE_CONFIG_H
> -I../../gdb/../include/opcode -I../../gdb/../readline/.. -I../bfd
> -I../../gdb/../bfd  -I../../gdb/../include -I../intl
> -I../../gdb/../intl  -DMI_OUT=1 -Wimplicit -Wreturn-type -Wcomment
> -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized
> -Werror ../../gdb/gdbarch.c
> cc1: warnings being treated as errors
> ../../gdb/gdbarch.c: In function
> `gdbarch_deprecated_max_register_raw_size_p':
> ../../gdb/gdbarch.c:3425: warning: comparison between pointer and integer
> ../../gdb/gdbarch.c: In function
> `gdbarch_deprecated_max_register_virtual_size_p':
> ../../gdb/gdbarch.c:3448: warning: comparison between pointer and integer
> ../../gdb/gdbarch.c: In function
> `gdbarch_deprecated_call_dummy_stack_adjust_p':
> ../../gdb/gdbarch.c:3805: warning: comparison between pointer and integer
> make: *** [gdbarch.o] Error 1
> 
> Is this related to your change?