From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20049 invoked by alias); 10 Jul 2003 19:03:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20041 invoked from network); 10 Jul 2003 19:03:03 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 10 Jul 2003 19:03:03 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BC9112B6E; Thu, 10 Jul 2003 15:03:03 -0400 (EDT) Message-ID: <3F0DB867.6070605@redhat.com> Date: Thu, 10 Jul 2003 19:03:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [patch, rfc] frame attribute - FRAME_IS_CALLER References: <3F0C7533.4090003@redhat.com> <20030709212907.GA27628@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00213.txt.bz2 > On Wed, Jul 09, 2003 at 04:04:03PM -0400, Andrew Cagney wrote: > >> Hello, >> >> Ref: Add frame_is_callee_p(), use in dwarf2-frame.c?, >> http://sources.redhat.com/ml/gdb-patches/2003-07/msg00046.html >> >> This patch adds a new `frame attribute' methods and defines one >> attribute `FRAME_IS_CALLER' (described in comment) (again better name?). >> >> It then uses it in a couple random places so that i know it is working. >> >> thoughts, >> >> The attached would be committed to the mainline, and just the new >> methods to the branch. >> >> Andrew > > > Shouldn't FRAME_IS_CALLER only be true if THIS->type == NORMAL_FRAME && > NEXT->type == NORMAL_FRAME? If NEXT->type == NORMAL_FRAME but > THIS->type == DUMMY_FRAME, then NEXT's return PC shouldn't be > decremented, et cetera. You mean, does a dummy frame `call' a normal frame? As far as the callee (the normal frame) is concerned, yes. It can't detect any thing different. It was called by the dummy frame. The assert this->type != DUMMY_FRAME probably wouldn't hurt frame_address_in_block though - the function is meaningless for dummy frames. Andrew