From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11695 invoked by alias); 3 Jul 2003 16:18:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11684 invoked from network); 3 Jul 2003 16:18:10 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 3 Jul 2003 16:18:10 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 754142B5F; Thu, 3 Jul 2003 12:18:07 -0400 (EDT) Message-ID: <3F04573F.8050803@redhat.com> Date: Thu, 03 Jul 2003 16:18:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: Add frame_is_callee_p(), use in dwarf2-frame.c? References: <3F0328AF.9080706@redhat.com> <20030702191249.GA24531@nevyn.them.org> <3F033272.3020508@redhat.com> <20030702193625.GA10838@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00078.txt.bz2 > On Wed, Jul 02, 2003 at 03:28:50PM -0400, Andrew Cagney wrote: > >> >Regardless, for a ``normal frame'' test, I'd like to suggest > >> >>``frame_is_callee_p()'' as something suitable descriptive. Thoughts? > >> > >> > >> >You've leapt ahead of me again. What would frame_is_callee_p mean? > >> >> The frame is a callee, it has a caller with a call instruction? > > > Oh, makes sense to me. But if you can think of a better name :-) The flip side would be to try something like ``frame is interrupt'' or `frame unwind is correct'', but then that gets into refinements like ``frame might be correct because of decr pc after break'' .... Andrew