From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23411 invoked by alias); 23 Jun 2003 20:38:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11764 invoked from network); 23 Jun 2003 20:34:09 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.131) by sources.redhat.com with SMTP; 23 Jun 2003 20:34:09 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4BD062B5F; Mon, 23 Jun 2003 16:31:48 -0400 (EDT) Message-ID: <3EF763B4.9080708@redhat.com> Date: Mon, 23 Jun 2003 20:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Fred Fish Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Don't clobber info->mach in gdb_print_insn_mips References: <20030623133919.2C2E92F2C23@beeville.vert.intrinsity.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00737.txt.bz2 > I updated to the latest CVS gdb over the weekend and afterwards my > mipsisa32-intrinsity-elf target would no longer disassemble > coprocessor 2 instructions correctly. I tracked it down to the > info->mach field being clobbered by gdb_print_insn_mips. The attached > patch fixes it, though I'm not sure if this is the correct solution. What happens if info->mach is never set? gdb_disassemble_info should have already set it correctly. Andrew > Note that mipsisa32-intrinsity-elf is not yet a supported target > configuration as it is a work in progress and the patches have not > been submitted yet. But mipsisa32-unknown-elf has a similar problem. >