From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21187 invoked by alias); 22 Jun 2003 17:59:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21157 invoked from network); 22 Jun 2003 17:59:23 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 22 Jun 2003 17:59:23 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id AA3AF2B63; Sun, 22 Jun 2003 13:59:17 -0400 (EDT) Message-ID: <3EF5EE75.70009@redhat.com> Date: Sun, 22 Jun 2003 17:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PR gdb/260: variables not expanded on the add-symbol-file command line References: <20030621223056.GB31184@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00702.txt.bz2 > This PR gets reported pretty regularly. Since the command line > overhaul I was hoping to do never materialized, does anyone object to > this patch to fix the specific problem in add-symbol-file? I believe > the patch is simple enough to have no copyright issues. > > The problem is that the code tries to parse and 0x > directly, and does not accept convenience variables. Yes, looks safe. Andrew