Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: "J. Johnston" <jjohnstn@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] linux-proc: use lwp instead of merged_pid in gcore files.
Date: Thu, 19 Jun 2003 19:53:00 -0000	[thread overview]
Message-ID: <3EF21334.8040906@redhat.com> (raw)
In-Reply-To: <3EF20660.30104@redhat.com>

J. Johnston wrote:
> J. Johnston wrote:
> 
>>
>>
>> Daniel Jacobowitz wrote:
>>
>>> On Wed, Jun 18, 2003 at 05:11:38PM -0700, Michael Snyder wrote:
>>>
>>>> Jeff, here's a patch that accomplishes the same thing as yours,
>>>> using mostly existing code and data.  I have tested it on old
>>>> linux threads, but not on nptl threads.
>>>>
>>>> Daniel, I went with your suggestion for "linux-nat.h", and I
>>>> moved one declaration from config/nm-linux.h to the new file.
>>>
>>>
>>>
>>>
>>> I'm not sure who's approval you're waiting for, but this looks might
>>> good to me.  Let's have someone with NPTL installed confirm it...
>>>
>>
>> Will do.
>>
>>> Oh, one nit.  Create $(linux_nat_h) in Makefile.in, please.
>>>
>>> [I'll switch to using linux-nat.h before committing the fork patch,
>>> once it's approved.  I'm not going to repost it now though.]
>>>
>>
>>
> 
> Tests run on x86 RH9.
> 
>         === gdb Summary ===
> 
> # of expected passes        8988
> # of unexpected failures    35
> # of unexpected successes    2
> # of expected failures        47
> # of known failures        31
> # of unresolved testcases    1
> # of unsupported tests        2
> 
> 
> the gdb.threads/gcore-thread.exp testcase ran successfully.

I'll take that as confirmation.  Consider this committed
(I'll get to it shortly).


> There is still a formatting mess for the output which you have already
> noticed.

Thanks for verifying that.  Shame none of the testsuites caught it...   ;-)



      reply	other threads:[~2003-06-19 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-19  0:11 Michael Snyder
2003-06-19  0:55 ` Daniel Jacobowitz
2003-06-19  1:23   ` Michael Snyder
2003-06-19 14:42   ` J. Johnston
2003-06-19 18:53     ` J. Johnston
2003-06-19 19:53       ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EF21334.8040906@redhat.com \
    --to=msnyder@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox