From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4658 invoked by alias); 18 Jun 2003 23:37:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4632 invoked from network); 18 Jun 2003 23:37:14 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.2) by sources.redhat.com with SMTP; 18 Jun 2003 23:37:14 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 6D48D80001E; Wed, 18 Jun 2003 19:37:14 -0400 (EDT) Message-ID: <3EF0F7AA.2050309@redhat.com> Date: Wed, 18 Jun 2003 23:37:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: RFA: gdb linux nptl patch 1 References: <3E84E672.3050506@redhat.com> <3EF0F0DF.2030802@redhat.com> <20030618231149.GA469@nevyn.them.org> <3EF0F456.2040504@redhat.com> <20030618232718.GA1104@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00612.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jun 18, 2003 at 04:23:02PM -0700, Michael Snyder wrote: > >>Daniel Jacobowitz wrote: >> >>>On Wed, Jun 18, 2003 at 04:08:15PM -0700, Michael Snyder wrote: >>> >>> >>>>J. Johnston wrote: >>>>[...] >>>> >>>> >>>>>This patch proposes adding a secondary list of thread_info structs that >>>>>keeps >>>>>track of the lwps. This list is kept distinct from the regular thread >>>>>list. >>>>>Since manipulating either list involves common operations, some base >>>>>operations >>>>>are added for generic thread_info list manipulation. The lin-lwp.c >>>>>layer is >>>>>changed to add and delete lwp thread_info structs to the lwp list when >>>>>lwps >>>>>are added or deleted. The linux-proc.c code is changed to iterate >>>>>through the >>>>>lwp thread_info list rather than the thread list when creating the >>>>>pr_status >>>>>notes. >>>> >>>>Jeff, did you realize that lin-lwp.c already maintains a list of lwps? >>>>It even exports an iterator function. I think this list you're adding >>>>may be redundant. >>> No. I didn't catch that, but it is a great idea. >>> >>>It exports an iterator, but you can't usefully declare the iterator's >>>callback anywhere, since struct lwp_info is local to lin-lwp.c... >>> >> >>No biggie, I'll just export that into a new file lin-lwp.h >>(along with a prototype of the iterator). > > > Sounds good. I've been using nm-linux.h for this sort of thing; but > how about... um... maybe linux-nat.h? That's a little more generic. >