From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3360 invoked by alias); 18 Jun 2003 23:23:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3318 invoked from network); 18 Jun 2003 23:23:05 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 18 Jun 2003 23:23:05 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5INN4H30467 for ; Wed, 18 Jun 2003 19:23:04 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5INN3S04470; Wed, 18 Jun 2003 19:23:03 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h5INN2K29080; Wed, 18 Jun 2003 16:23:03 -0700 Message-ID: <3EF0F456.2040504@redhat.com> Date: Wed, 18 Jun 2003 23:23:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz CC: "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: RFA: gdb linux nptl patch 1 References: <3E84E672.3050506@redhat.com> <3EF0F0DF.2030802@redhat.com> <20030618231149.GA469@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00607.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jun 18, 2003 at 04:08:15PM -0700, Michael Snyder wrote: > >>J. Johnston wrote: >>[...] >> >>>This patch proposes adding a secondary list of thread_info structs that >>>keeps >>>track of the lwps. This list is kept distinct from the regular thread >>>list. >>>Since manipulating either list involves common operations, some base >>>operations >>>are added for generic thread_info list manipulation. The lin-lwp.c >>>layer is >>>changed to add and delete lwp thread_info structs to the lwp list when lwps >>>are added or deleted. The linux-proc.c code is changed to iterate >>>through the >>>lwp thread_info list rather than the thread list when creating the >>>pr_status >>>notes. >> >>Jeff, did you realize that lin-lwp.c already maintains a list of lwps? >>It even exports an iterator function. I think this list you're adding >>may be redundant. > > > It exports an iterator, but you can't usefully declare the iterator's > callback anywhere, since struct lwp_info is local to lin-lwp.c... > No biggie, I'll just export that into a new file lin-lwp.h (along with a prototype of the iterator).