From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3565 invoked by alias); 13 Jun 2003 04:18:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3517 invoked from network); 13 Jun 2003 04:17:57 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 13 Jun 2003 04:17:57 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D90252B5F; Fri, 13 Jun 2003 00:17:48 -0400 (EDT) Message-ID: <3EE9506C.9060902@redhat.com> Date: Fri, 13 Jun 2003 04:18:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: always_use_struct_convention References: <3EE72AD9.4090609@redhat.com> Content-Type: multipart/mixed; boundary="------------070401080708070407080906" X-SW-Source: 2003-06/txt/msg00450.txt.bz2 This is a multi-part message in MIME format. --------------070401080708070407080906 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1575 > This is almost obvious... > > 2003-06-11 Jim Blandy > > * arch-utils.c (always_use_struct_convention): New function. > * arch-utils.h (always_use_struct_convention): New prototype. > * alpha-tdep.c (alpha_use_struct_convention): Delete. > (alpha_gdbarch_init): Register always_use_struct_convention, > instead of alpha_use_struct_convention. > * cris-tdep.c (cris_use_struct_convention): Delete. > (cris_gdbarch_init): Register always_use_struct_convention, > instead of cris_use_struct_convention. > * frv-tdep.c (frv_use_struct_convention): Delete. > (frv_gdbarch_init): Register always_use_struct_convention, > instead of frv_use_struct_convention. > * h8300-tdep.c (h8300_use_struct_convention): Delete. > (h8300_gdbarch_init): Register always_use_struct_convention, > instead of h8300_use_struct_convention. > * mips_o32-tdep.c (mips_o32_use_struct_convention): Delete. > (mips_o32_gdbarch_init): Register always_use_struct_convention, > instead of mips_o32_use_struct_convention. > > No, it is obvious :-) Nice catch. Well, almost. The patch broke mips-elf :-( /home/cagney/PENDING/2003-06-12-deprecate-register/src/gdb/mips-tdep.c: In function `mips_gdbarch_init': /home/cagney/PENDING/2003-06-12-deprecate-register/src/gdb/mips-tdep.c:5794: `mips_o32_use_struct_convention' undeclared (first use in this function) Please be sure to check that the change doesn' break the cross target builds. The script gdb/gdb_mbuild.sh helps. I checked in the attached. Andrew --------------070401080708070407080906 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 908 2003-06-13 Andrew Cagney * mips-tdep.c (mips_gdbarch_init): Replace remaining instances of mips_o32_use_struct_convention with always_use_struct_convention. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.212 diff -u -r1.212 mips-tdep.c --- mips-tdep.c 12 Jun 2003 23:25:37 -0000 1.212 +++ mips-tdep.c 13 Jun 2003 04:16:14 -0000 @@ -5790,8 +5790,7 @@ set_gdbarch_long_long_bit (gdbarch, 64); set_gdbarch_reg_struct_has_addr (gdbarch, mips_o32_reg_struct_has_addr); - set_gdbarch_use_struct_convention (gdbarch, - mips_o32_use_struct_convention); + set_gdbarch_use_struct_convention (gdbarch, always_use_struct_convention); break; case MIPS_ABI_EABI32: set_gdbarch_push_dummy_call (gdbarch, mips_eabi_push_dummy_call); --------------070401080708070407080906--