I've checked in the attached having removed anything someone didn't like :-) > I thought someone might comment, that's why I tried to make what was happening very clear :-) > > It's a real trade off. > > -- delay -Wmissing-prototypes until multi-arch is finished > > -- move the declarations so that they are always visible > > -- drop -Werror for certain architectures > > Given the problems that -Wmissing-prototypes has thrown up (extern in .c, forgetting to include .h), I'd prefer to see it enabled. > > Also note the number of *-tdep.c functions I make static. It's pretty clear that people deleting the #define/declaration consistently forget to update the corresponding function definition. > > I think a better way of handling these stray global declarations would be to use some sort of real code analysis tool (which the ari isn't :-). So ... Andrew