Re: [patch rfc] -Wmissing-prototypes round #3

Kevin Buettner
2003-06-11T20:31:50Z

On Jun 11, 1:42pm, Andrew Cagney wrote:

> This is the next round of fixes for -Wmissing-prototypes. This patch:
>
> - add missing function declarations to CPU-tdep.h
> Ex, the externs in ia64-tdep.c were replaced by declarations in the
> corresponding .h file
[...]
>
> - where needed, create missing CPU-tdep.h files
> Ex: sparc-tdep.h and ia64-aix-tdep.h being created.
> This again ensures that foo.c's function declaration is in foo.h.

Some comments with regard to IA-64:

1) I'd rather have the declarations for
ia64_linux_sigcontext_register_address() and
ia64_aix_sigcontext_register_address() go into a single ia64-tdep.h
file. I think having two files is overkill.

2) However, even that shouldn't be necessary. Now that we have the
OSABI machinery, it should be possible to solve the problem without
having to export these functions at all.

Kevin