Re: [patch rfc] -Wmissing-prototypes round #3

Mark Kettenis
2003-06-11T18:56:47Z

Andrew Cagney <ac131313@redhat.com> writes:

> - move function declarations to CPU-tdep.h, from config/CPU/tm-CPU.h
> Ex, m68k's delta68 functions previously in tm-delta.h.
> This ensures that the function declaration is always visible, and that a
> global function in CPU-tdep.c has its declaration in the corresponding
> CPU-tdep.h file. The config/CPU/tm-CPU.h files were also updated to
> include the corresponding "CPU-tdep.h".

I'm not sure whether this part of your patch is a good idea. Quite a
number of function declarations in config/CPU/tm-CPU.h are for things
that haven't been multi-arched yet. Keeping the function declaration
next to the #define that uses them, makes it easier to remove them
once they're no longer needed.

Mark