From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3577 invoked by alias); 11 Jun 2003 23:35:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3543 invoked from network); 11 Jun 2003 23:35:08 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 11 Jun 2003 23:35:08 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id A9513800030; Wed, 11 Jun 2003 19:35:07 -0400 (EDT) Message-ID: <3EE7BCAB.3030600@redhat.com> Date: Wed, 11 Jun 2003 23:35:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: patch to convert_doublest_to_floatformat in doublest.c References: <3EE62E90.1000806@redhat.com> <1030611221540.ZM27025@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00400.txt.bz2 Patch checked in. Thanks. -- Jeff J. Kevin Buettner wrote: > On Jun 10, 3:16pm, J. Johnston wrote: > > >> * doublest.c (convert_doublest_to_floatformat): When dealing with the implied >> integer bit, only alter mant_bits if we are processing a full 32 bits of >> mantissa. >> >>Index: doublest.c >>=================================================================== >>RCS file: /cvs/src/src/gdb/doublest.c,v >>retrieving revision 1.15 >>diff -u -p -r1.15 doublest.c >>--- doublest.c 8 Jun 2003 18:27:13 -0000 1.15 >>+++ doublest.c 10 Jun 2003 18:44:30 -0000 >>@@ -404,7 +404,15 @@ convert_doublest_to_floatformat (CONST s >> { >> mant_long <<= 1; >> mant_long &= 0xffffffffL; >>- mant_bits -= 1; >>+ /* If we are processing the top 32 mantissa bits of a doublest >>+ so as to convert to a float value with implied integer bit, >>+ we will only be putting 31 of those 32 bits into the >>+ final value due to the discarding of the top bit. In the >>+ case of a small float value where the number of mantissa >>+ bits is less than 32, discarding the top bit does not alter >>+ the number of bits we will be adding to the result. */ >>+ if (mant_bits == 32) >>+ mant_bits -= 1; >> } >> >> if (mant_bits < 32) > > > Okay. > > Kevin >