From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29047 invoked by alias); 11 Jun 2003 21:25:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28989 invoked from network); 11 Jun 2003 21:25:48 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 11 Jun 2003 21:25:48 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 2F54D800041; Wed, 11 Jun 2003 17:25:48 -0400 (EDT) Message-ID: <3EE79E5C.2080209@redhat.com> Date: Wed, 11 Jun 2003 21:25:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: patch to convert_doublest_to_floatformat in doublest.c References: <3EE62E90.1000806@redhat.com> <1030611211955.ZM26801@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00388.txt.bz2 Kevin Buettner wrote: > On Jun 10, 3:16pm, J. Johnston wrote: > > >>The old algorithm is correct for floating values whereby there are >>32 or more mantissa bits. In such a case, we only can put 31 bits >>into the result. A simple test was added. The patch has been >>tested on the ia64 and x86. > > > I'm wondering about the test that you added. You say that the old > algorithm was correct for 32 or *more* mantissa bits. Yet the test > you added is as follows: > > >>+ if (mant_bits == 32) > > > I'm wondering if this should instead be: > > if (mant_bits >= 32) > > ? > > Kevin > No, it is ok. The algorithm only processes 32 bits at a time. If you look earlier, you will see: mant_bits = mant_bits_left < 32 ? mant_bits_left : 32; -- Jeff J.