From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22051 invoked by alias); 11 Jun 2003 20:59:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21867 invoked from network); 11 Jun 2003 20:59:12 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.131) by sources.redhat.com with SMTP; 11 Jun 2003 20:59:12 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E6DD02B63; Wed, 11 Jun 2003 16:59:05 -0400 (EDT) Message-ID: <3EE79819.4090207@redhat.com> Date: Wed, 11 Jun 2003 20:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch rfc] -Wmissing-prototypes round #3 References: <3EE76A05.2050409@redhat.com> <1030611203142.ZM26545@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00384.txt.bz2 > On Jun 11, 1:42pm, Andrew Cagney wrote: > > >> This is the next round of fixes for -Wmissing-prototypes. This patch: >> >> - add missing function declarations to CPU-tdep.h >> Ex, the externs in ia64-tdep.c were replaced by declarations in the >> corresponding .h file > > [...] > >> >> - where needed, create missing CPU-tdep.h files >> Ex: sparc-tdep.h and ia64-aix-tdep.h being created. >> This again ensures that foo.c's function declaration is in foo.h. > > > Some comments with regard to IA-64: > > 1) I'd rather have the declarations for > ia64_linux_sigcontext_register_address() and > ia64_aix_sigcontext_register_address() go into a single ia64-tdep.h > file. I think having two files is overkill. I'ts 6 of one half dozen of the other. At least it's clear which .c file the .h declaration belongs to. If someone later eliminates it, all the better. > 2) However, even that shouldn't be necessary. Now that we have the > OSABI machinery, it should be possible to solve the problem without > having to export these functions at all. In the mean time I'd like to get -Wmissing-prototypes enabled. Andrew