Re: [patch rfc] -Wmissing-prototypes round #3

Andrew Cagney
2003-06-11T20:59:14Z

> On Jun 11, 1:42pm, Andrew Cagney wrote:
>
>
>> This is the next round of fixes for -Wmissing-prototypes. This patch:
>>
>> - add missing function declarations to CPU-tdep.h
>> Ex, the externs in ia64-tdep.c were replaced by declarations in the
>> corresponding .h file
>
> [...]
>
>>
>> - where needed, create missing CPU-tdep.h files
>> Ex: sparc-tdep.h and ia64-aix-tdep.h being created.
>> This again ensures that foo.c's function declaration is in foo.h.
>
>
> Some comments with regard to IA-64:
>
> 1) I'd rather have the declarations for
> ia64_linux_sigcontext_register_address() and
> ia64_aix_sigcontext_register_address() go into a single ia64-tdep.h
> file. I think having two files is overkill.

I'ts 6 of one half dozen of the other. At least it's clear which .c
file the .h declaration belongs to. If someone later eliminates it, all
the better.

> 2) However, even that shouldn't be necessary. Now that we have the
> OSABI machinery, it should be possible to solve the problem without
> having to export these functions at all.

In the mean time I'd like to get -Wmissing-prototypes enabled.

Andrew