From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 625 invoked by alias); 4 Jun 2003 03:09:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 578 invoked from network); 4 Jun 2003 03:09:50 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 4 Jun 2003 03:09:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A3EEC2B2F; Tue, 3 Jun 2003 23:09:39 -0400 (EDT) Message-ID: <3EDD62F3.3060306@redhat.com> Date: Wed, 04 Jun 2003 03:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: Last build failure in alpha-osf1-tdep.c (I promise :) References: <20030604004536.GQ919@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00159.txt.bz2 > A recent change in the tdep structure for the alpha target caused a > build failure on Tru64: skip_sigtramp_frame has been removed. > > I really don't know what to do to fix this. It looks like Richard has > implemented a better unwinder in alpha-mdebug-tdep, which I should be > able to use on Tru64 as well. Here is just a diff showing the little > play on sources I did in order to illustrate my changes. > > I haven't had time to look at this closer, so I don't know what I'm > doing. Help, please? The function was being called from: static CORE_ADDR alpha_frame_chain (struct frame_info *frame) but that's now all gone. In its place are per-frame frame unwinders. In the alpha there are: alpha_sigtramp_frame_this_id() alpha_heuristic_frame_this_id() alpha_mdebug_frame_this_id() > * config/alpha/alpha-osf1.mt (TDEPFILES): Add alpha-mdebug-tdep.o. Check alpha-linux-tdep.c, you'll want to steal the call: /* Hook into the MDEBUG frame unwinder. */ alpha_mdebug_init_abi (info, gdbarch); adding it to alpha-osf1-tdep.c. That will enable mdebug. > * alpha-osf1-tdep.c (alpha_osf1_init_abi): Do not set > skip_sigtramp_frame in tdep structure, field no longer exists. Check this in. In fact, consider a patch to delete all occurances of that function across alpha*tdep.c pre-approved. Andrew > Index: alpha-osf1-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/alpha-osf1-tdep.c,v > retrieving revision 1.12 > diff -c -3 -p -r1.12 alpha-osf1-tdep.c > *** alpha-osf1-tdep.c 3 Jun 2003 23:49:32 -0000 1.12 > --- alpha-osf1-tdep.c 4 Jun 2003 00:32:06 -0000 > *************** alpha_osf1_init_abi (struct gdbarch_info > *** 95,101 **** > argument handling and bp_call_dummy takes care of stopping the dummy. */ > set_gdbarch_call_dummy_address (gdbarch, alpha_call_dummy_address); > > - tdep->skip_sigtramp_frame = alpha_osf1_skip_sigtramp_frame; > tdep->sigcontext_addr = alpha_osf1_sigcontext_addr; > > tdep->jb_pc = 2; > --- 99,104 ---- > Index: config/alpha/alpha-osf1.mt > =================================================================== > RCS file: /cvs/src/src/gdb/config/alpha/alpha-osf1.mt,v > retrieving revision 1.2 > diff -c -3 -p -r1.2 alpha-osf1.mt > *** config/alpha/alpha-osf1.mt 25 Apr 2002 02:28:57 -0000 1.2 > --- config/alpha/alpha-osf1.mt 4 Jun 2003 00:32:07 -0000 > *************** > *** 1,3 **** > # Target: Little-endian Alpha > ! TDEPFILES= alpha-tdep.o alpha-osf1-tdep.o > TM_FILE= tm-alpha.h > --- 1,3 ---- > # Target: Little-endian Alpha > ! TDEPFILES= alpha-tdep.o alpha-osf1-tdep.o alpha-mdebug-tdep.o > TM_FILE= tm-alpha.h