From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-24834-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 10373 invoked by alias); 2 Jun 2003 18:40:11 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 10351 invoked from network); 2 Jun 2003 18:40:11 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.131)
  by sources.redhat.com with SMTP; 2 Jun 2003 18:40:11 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 79F7E2B2F; Mon,  2 Jun 2003 14:40:05 -0400 (EDT)
Message-ID: <3EDB9A05.8050609@redhat.com>
Date: Mon, 02 Jun 2003 18:40:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Richard Henderson <rth@twiddle.net>
Cc: Mark Kettenis <kettenis@chello.nl>,
	gdb-patches@sources.redhat.com
Subject: Re: [RFA] update alpha return value hooks to regcache
References: <20030602052612.GA7505@twiddle.net> <86znl08n1j.fsf@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-06/txt/msg00078.txt.bz2

> Richard Henderson <rth@twiddle.net> writes:
> 
> 
>> Ok?
>> 
>> r~
>> 
>> 	* alpha-tdep.c (alpha_extract_return_value): Convert to regcache.
>> 	(alpha_extract_struct_value_address): Likewise.
>> 	(alpha_store_return_value): Likewise.
>> 	(alpha_store_struct_return): Remove.
>> 	(alpha_gdbarch_init): Update hook registration to match.
>>
> 
> 
> Ah, this one's got a flaw.  Using abort() isn't allowed in GDB.
> Instead use internal_error() which gives the user the option of
> continuing at his/her own risk.  You could also use gdb_assert()
> (which calls internal_error()).
> 
> With that change, this is approved.

BTW, also:

> ! 	case 4:
> ! 	  alpha_convert_flt_dbl (raw_buffer, valbuf);
> ! 	  valbuf = raw_buffer;
> ! 	  /* FALLTHRU */
> ! 
> ! 	case 8:
> ! 	  regcache_cooked_write (regcache, ALPHA_FP0_REGNUM, valbuf);
> ! 	  break;
> ! 
> ! 	default:
> ! 	  abort ();

please avoid the fallthrough.

Andrew