From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11814 invoked by alias); 1 Jun 2003 23:02:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9996 invoked from network); 1 Jun 2003 23:01:43 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 1 Jun 2003 23:01:43 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id EBF6A2B2F; Sun, 1 Jun 2003 19:01:34 -0400 (EDT) Message-ID: <3EDA85CE.8030401@redhat.com> Date: Sun, 01 Jun 2003 23:02:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: Kevin Buettner , gdb-patches@sources.redhat.com Subject: Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib References: <3ECD1E75.9020900@redhat.com> <1030522194129.ZM31026@localhost.localdomain> <3ECE607C.7060902@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00036.txt.bz2 > On May 22, 3:01pm, Andrew Cagney wrote: > > > This does the s/extract_address/extract_unsigned_integer/ change to the solib files. > > One bit bugs me - IRIX. It's doing an unsigned extract when MIPS is ment to always sign extend an address. It's very tempting to instead make that code always do signextended extracts (I don't have access to an IRIX 4 box though). > > thoughts? > > > It looks okay to me. > > I agree that extract_mips_address() in solib-irix.c probably ought to > be using extract_signed_integer(), but I too am reluctant to change it > without testing. > > Why do you need an IRIX 4 box? Wouldn't IRIX 6 work? > > Do you have a good test case? On IRIX 6, shlib-call.exp fails with: > > FAIL: gdb.base/shlib-call.exp: print shr1(1) > FAIL: gdb.base/shlib-call.exp: print shr1(g) > FAIL: gdb.base/shlib-call.exp: run until breakpoint set at a function > FAIL: gdb.base/shlib-call.exp: print shr1(1) 2nd time > FAIL: gdb.base/shlib-call.exp: step out of shr2 > FAIL: gdb.base/shlib-call.exp: print mainshr1(1) from main > FAIL: gdb.base/shlib-call.exp: step into mainshr1 > > with/without the change. The other solib* tests are hp specific :-/ I fixed these failures. It now passes, even with extract_signed_address so I've committed that. Andrew