From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26690 invoked by alias); 1 Jun 2003 22:55:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26183 invoked from network); 1 Jun 2003 22:55:38 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 1 Jun 2003 22:55:38 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C31732B2F; Sun, 1 Jun 2003 18:55:27 -0400 (EDT) Message-ID: <3EDA845F.6090407@redhat.com> Date: Sun, 01 Jun 2003 22:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Adam Fedor Cc: GDB Patches , Daniel Jacobowitz Subject: Re: [RFA]: gdbarch FETCH_POINTER_ARGUMENT References: <3EC84B9A.8030505@doc.com> <3ECA8AF1.10001@redhat.com> <3ECD2201.5040306@redhat.com> <3ED6CA78.9010109@doc.com> <3ED7B064.3020708@redhat.com> <3ED97ADC.5070405@doc.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00035.txt.bz2 > Andrew Cagney wrote: > > Here's an updated patch. The more I looked at the "struct type *type" argument, the less I understood about how it should be used. I assume it would only be used, so far, on i386, but I'm easily confused by stacks and registers (and how things are stored there), so any pointers would be appreciated. > > > The patch is almost fine. Change it to `F' instead of `f' - so that a predicate is also available. > > > OK, I made this change. > > > > 2003-05-18 Adam Fedor > > * gdbarch.sh (function_list): Add FETCH_POINTER_ARGUMENT. > * gdbarch.[ch]: Regenerate. > * hppa-tdep.c (hppa_fetch_pointer_argument): New function. > (hppa_gdbarch_init): Set it in the gdbarch vector. > * i386-tdep.c (i386_fetch_pointer_argument): New > (i386_gdbarch_init): Set it into gdbarch. > * rs6000-tdep.c (rs6000_fetch_pointer_argument): New. > (rs6000_gdbarch_init): Set it in gdbarch. > * sparc-tdep.c (sparc_fetch_pointer_argument): New > (sparc_gdbarch_init): Set it in gdbarch. > Ok! Be sure to re-run gdbarch.sh before committing - I made a change that will affect the generate gdbarch.[hc] files. Andrew