From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6045 invoked by alias); 23 May 2003 17:59:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28890 invoked from network); 23 May 2003 17:55:17 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.131) by sources.redhat.com with SMTP; 23 May 2003 17:55:17 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A690C2B2F; Fri, 23 May 2003 13:55:08 -0400 (EDT) Message-ID: <3ECE607C.7060902@redhat.com> Date: Fri, 23 May 2003 17:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib References: <3ECD1E75.9020900@redhat.com> <1030522194129.ZM31026@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00462.txt.bz2 > On May 22, 3:01pm, Andrew Cagney wrote: > > >> This does the s/extract_address/extract_unsigned_integer/ change to the >> solib files. >> >> One bit bugs me - IRIX. It's doing an unsigned extract when MIPS is >> ment to always sign extend an address. It's very tempting to instead >> make that code always do signextended extracts (I don't have access to >> an IRIX 4 box though). >> >> thoughts? > > > It looks okay to me. > > I agree that extract_mips_address() in solib-irix.c probably ought to > be using extract_signed_integer(), but I too am reluctant to change it > without testing. > > Why do you need an IRIX 4 box? Wouldn't IRIX 6 work? Do you have a good test case? On IRIX 6, shlib-call.exp fails with: FAIL: gdb.base/shlib-call.exp: print shr1(1) FAIL: gdb.base/shlib-call.exp: print shr1(g) FAIL: gdb.base/shlib-call.exp: run until breakpoint set at a function FAIL: gdb.base/shlib-call.exp: print shr1(1) 2nd time FAIL: gdb.base/shlib-call.exp: step out of shr2 FAIL: gdb.base/shlib-call.exp: print mainshr1(1) from main FAIL: gdb.base/shlib-call.exp: step into mainshr1 with/without the change. The other solib* tests are hp specific :-/ Andrew