From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9665 invoked by alias); 21 May 2003 22:31:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9602 invoked from network); 21 May 2003 22:31:21 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 21 May 2003 22:31:21 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 9926380001E for ; Wed, 21 May 2003 18:31:20 -0400 (EDT) Message-ID: <3ECBFE38.4020701@redhat.com> Date: Wed, 21 May 2003 22:31:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: RFA: patch to infptrace.c Content-Type: multipart/mixed; boundary="------------040401040702000601030009" X-SW-Source: 2003-05/txt/msg00411.txt.bz2 This is a multi-part message in MIME format. --------------040401040702000601030009 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 551 The attached patch changes the ptrace detach call to not perform error handling when an error occurs in detach. Without this patch, an error in detach stops gdb from exiting. The error keeps returning to the command line over and over again. I thought I had fixed this earlier by adding a check for errno != ESRCH, but it appears there are other scenarios that may occur. Ok to commit? -- Jeff J. 2003-05-21 Jeff Johnston * infptrace.c (detach): Call print_sys_errmsg when an error occurs instead of perror_with_name. --------------040401040702000601030009 Content-Type: text/plain; name="infptrace.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="infptrace.patch" Content-length: 559 Index: infptrace.c =================================================================== RCS file: /cvs/src/src/gdb/infptrace.c,v retrieving revision 1.25 diff -u -p -r1.25 infptrace.c --- infptrace.c 8 May 2003 20:52:47 -0000 1.25 +++ infptrace.c 21 May 2003 21:39:56 -0000 @@ -302,7 +302,7 @@ detach (int signal) ptrace (PT_DETACH, PIDGET (inferior_ptid), (PTRACE_ARG3_TYPE) 1, signal); if (errno && errno != ESRCH) - perror_with_name ("ptrace"); + print_sys_errmsg ("ptrace", errno); attach_flag = 0; } #endif /* ATTACH_DETACH */ --------------040401040702000601030009--