From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9881 invoked by alias); 5 May 2003 17:58:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9874 invoked from network); 5 May 2003 17:58:26 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 5 May 2003 17:58:26 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 89B302B2F; Mon, 5 May 2003 13:58:23 -0400 (EDT) Message-ID: <3EB6A63F.3020506@redhat.com> Date: Mon, 05 May 2003 17:58:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Cc: Eli Zaretskii Subject: Re: [patch rfc] Dummy deprecate deluge References: <3EB48DBC.1040106@redhat.com> <3405-Mon05May2003061649+0300-eliz@elta.co.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00070.txt.bz2 > Hello, > > This deprecates all but one of the now defunct dummy methods. I need to investigate call_dummy_address to see if it two is no longer needed. > > One, REGISTER_SIZE deserves a few comments. > > In infcall.c, the dummy frame code uses REGISTER_SIZE to figure out how to convert the dummy frame words from host to target byte order: > > /* CALL_DUMMY is an array of words (REGISTER_SIZE), but each word is > in host byte order. Before calling FIX_CALL_DUMMY, we byteswap > it and remove any extra bytes which might exist because ULONGEST > is bigger than REGISTER_SIZE. */ > /* NOTE: This is pretty wierd, as the call dummy is actually a > sequence of instructions. But CISC machines will have to pack > the instructions into REGISTER_SIZE units (and so will RISC > machines for which INSTRUCTION_SIZE is not REGISTER_SIZE). */ > /* NOTE: This is pretty stupid. CALL_DUMMY should be in strict > target byte order. */ > > The whole dummy mess is replaced by push_dummy_code(). I also found mi/mi-main.c: > > /* Get the value into an array */ > buffer = xmalloc (REGISTER_SIZE); > old_chain = make_cleanup (xfree, buffer); > store_signed_integer (buffer, REGISTER_SIZE, value); > /* Write it down */ > deprecated_write_register_bytes (REGISTER_BYTE (regnum), buffer, REGIS > TER_RAW_SIZE (regnum)); > > I'm not sure what this one is smoking, it suspect that it should have used REGISTER_RAW_SIZE(). I've checked this in. Andrew > 2003-05-03 Andrew Cagney > > * gdbarch.sh (DEPRECATED_REGISTER_SIZE): Rename REGISTER_SIZE. > (DEPRECATED_SIZEOF_CALL_DUMMY_WORDS): Rename > SIZEOF_CALL_DUMMY_WORDS. > (DEPRECATED_CALL_DUMMY_WORDS): Rename CALL_DUMMY_WORDS. > (DEPRECATED_FIX_CALL_DUMMY): Rename FIX_CALL_DUMMY. > (DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET): Rename > CALL_DUMMY_BREAKPOINT_OFFSET. > (DEPRECATED_CALL_DUMMY_START_OFFSET): Rename > CALL_DUMMY_START_OFFSET. > (DEPRECATED_CALL_DUMMY_LENGTH): Rename CALL_DUMMY_LENGTH. > * gdbarch.h, gdbarch.c: Re-generate. > * alpha-tdep.c, alphafbsd-tdep.c, arm-linux-tdep.c: Update. > * arm-tdep.c, avr-tdep.c, breakpoint.c, cris-tdep.c: Update. > * dummy-frame.c, dummy-frame.h, frv-tdep.c, gdbarch.c: Update. > * gdbarch.h, gdbarch.sh, h8300-tdep.c, hppa-tdep.c: Update. > * i386-tdep.c, ia64-tdep.c, infcall.c, inferior.h: Update. > * m68hc11-tdep.c, m68k-tdep.c, mcore-tdep.c: Update. > * mips-tdep.c, mn10300-tdep.c, ns32k-tdep.c: Update. > * rs6000-tdep.c, s390-tdep.c, sh-tdep.c, sol-thread.c: Update. > * sparc-tdep.c, target.c, v850-tdep.c, valops.c: Update. > * vax-tdep.c, x86-64-tdep.c, xstormy16-tdep.c: Update. > * config/ia64/tm-ia64.h, config/m68k/tm-vx68.h: Update. > * config/mips/tm-mips.h, config/pa/nm-hppah.h: Update. > * config/pa/tm-hppa.h, config/pa/tm-hppa64.h: Update. > * config/s390/tm-s390.h, config/sparc/tm-sp64.h: Update. > * config/sparc/tm-sparc.h: Update. > > Index: doc/ChangeLog > 2003-05-03 Andrew Cagney > > * gdbint.texinfo (Target Architecture Definition): Make > CALL_DUMMY_WORDS, SIZEOF_CALL_DUMMY_WORDS, CALL_DUMMY_LENGTH, > FIX_CALL_DUMMY, CALL_DUMMY_BREAKPOINT_OFFSET and > CALL_DUMMY_BREAKPOINT_OFFSET deprecated. > > Index: mi/ChangeLog > 2003-05-03 Andrew Cagney > > * mi-main.c (mi_cmd_data_write_register_values): Replace > REGISTER_SIZE with DEPRECATED_REGISTER_SIZE. > > Index: testsuite/ChangeLog > 2003-05-03 Andrew Cagney > > * gdb.base/watchpoint.exp: Rename CALL_DUMMY_BREAKPOINT_OFFSET to > DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET in comments. >