From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27300 invoked by alias); 30 Apr 2003 22:01:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27277 invoked from network); 30 Apr 2003 22:01:24 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 30 Apr 2003 22:01:24 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 45C812B48; Wed, 30 Apr 2003 18:01:18 -0400 (EDT) Message-ID: <3EB047AE.1080906@redhat.com> Date: Wed, 30 Apr 2003 23:13:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, insight@sources.redhat.com Subject: Re: [patch rfc] Deprecate tm_print_insn_info References: <3EAD89B2.4050401@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00551.txt.bz2 > Hello, > > This patch cleans up / deprecates: > > tm_print_insn_info > TARGET_PRINT_INSN_INFO > dis_asm_print_address > dis_asm_memory_read > dis_asm_memory_error > > they are merged into a single: > > deprecated_tm_print_insn_info > > that lives in "disasm.c". It would all be static, with "deprecated_tm_print_insn_info" deleted, if it were not for some accesses that still need eliminating (at least it is now possible to find them). > > Note that "printcmd.c" is still using deprecated_tm_print_insn_info instead of gdb_disassemble. Turns out that further gdb_disassemble fixes are needed - the "sim" target has the same problems as "core", "thread", "procfs", .... Fix to follow. I've checked this in. > Index: ChangeLog > 2003-04-28 Andrew Cagney > > * gdbarch.sh (deprecated_tm_print_insn_info): Rename > "tm_print_insn_info". > (TARGET_PRINT_INSN_INFO): Delete macro. > (dis_asm_read_memory): Delete function declaration. > (dis_asm_memory_error, dis_asm_print_address): Ditto. > (tm_print_insn_info): Delete variable definition. > (_initialize_gdbarch): Do not initialize "tm_print_insn_info". > * gdbarch.h, gdbarch.c: Re-generate. > * d10v-tdep.c (display_trace): Replace "tm_print_insn_info" with > "deprecated_tm_print_insn_info". > * mcore-tdep.c (mcore_dump_insn): Ditto. > * mips-tdep.c (mips_gdbarch_init): Ditto. > * sparc-tdep.c (_initialize_sparc_tdep): Ditto. > * v850-tdep.c (v850_scan_prologue, v850_gdbarch_init): Ditto. > * ia64-tdep.c (_initialize_ia64_tdep): Ditto. > * printcmd.c (print_insn): Use "deprecated_tm_print_insn_info" > instead of TARGET_PRINT_INSN_INFO, add comment. > * s390-tdep.c (s390_get_frame_info): Instead of > "dis_asm_read_memory", use "deprecated_tm_print_insn_info". > (s390_check_function_end, s390_is_sigreturn): Ditto. > * corefile.c (dis_asm_read_memory): Move to "disasm.c". > (dis_asm_memory_error, dis_asm_print_address): Ditto. > * disasm.c: Include "gdbcore.h". > (_initialize_disasm): New function, initialize > "deprecated_tm_print_insn_info". > (deprecated_tm_print_insn_info): New variable. > (dis_asm_read_memory): Moved from "corefile.c", made static. > (dis_asm_print_address, dis_asm_memory_error): Ditto. > * Makefile.in (disasm.o): Update dependencies. > > Index: gdbtk/ChangeLog > 2003-04-28 Andrew Cagney > > * generic/gdbtk-cmds.c (gdb_disassemble_driver): Instead of > TARGET_PRINT_INSN_INFO, "dis_asm_memory_error", > "dis_asm_read_memory", and "dis_asm_print_address", use > "deprecated_tm_print_insn_info" > > Index: tui/ChangeLog > 2003-04-28 Andrew Cagney > > * tuiDisassem.c (tui_disassemble): Use > "deprecated_tm_print_insn_info" instead of TARGET_PRINT_INSN_INFO, > add comment. >