From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30499 invoked by alias); 23 Apr 2003 14:23:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30492 invoked from network); 23 Apr 2003 14:23:53 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 23 Apr 2003 14:23:53 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 8AF3F2B2F; Wed, 23 Apr 2003 10:23:52 -0400 (EDT) Message-ID: <3EA6A1F8.1060502@redhat.com> Date: Wed, 23 Apr 2003 17:37:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jason Molenda Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Add type_sprint() function to return type in string form References: <20030418152426.A93348@molenda.com> <20030423013217.A51438@molenda.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00437.txt.bz2 > Hi all, here's the follow-up patch incorporating the comments. > > I didn't have time to make a test case for this. I want to at least > elicit the error message before I commit this, so I'll get something > together tomorrow night or the night after. I don't know how easy > it will be to add to the testsuite, but I'll at least do something > by hand to get the error. I assume this is in. I'm just amazed that the existing testsuite didn't trigger this. Even a simple tweak of an existing test should do the trick. Andrew > 2003-04-23 Jason Molenda (jmolenda at apple dot com) > > * typeprint.c (type_xasprint): New function to return human-readable > string representation of a type. > * value.h (type_xasprint): Add prototype. > * ada-lang.c (ada_lookup_struct_elt_type): Use type_xasprint() when > building error message. > * gdbtypes.c (lookup_struct_elt_type): Ditto. > * varobj.c (varobj_get_type): Use type_xasprint() to get the type > in a string form. > >