From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31452 invoked by alias); 22 Apr 2003 17:29:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31432 invoked from network); 22 Apr 2003 17:29:00 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 22 Apr 2003 17:29:00 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B8BCF2B2F; Tue, 22 Apr 2003 13:28:57 -0400 (EDT) Message-ID: <3EA57BD9.5020502@redhat.com> Date: Tue, 22 Apr 2003 17:29:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Jason Molenda , gdb-patches@sources.redhat.com Subject: Re: PATCH: Add type_sprint() function to return type in string form References: <20030418152426.A93348@molenda.com> <20030422032629.GB5033@nevyn.them.org> <3EA57249.5020104@redhat.com> <20030422165455.GA31686@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00402.txt.bz2 > On Tue, Apr 22, 2003 at 12:48:09PM -0400, Andrew Cagney wrote: > >> >On Fri, Apr 18, 2003 at 03:24:26PM -0700, Jason Molenda wrote: >> > > >> >>There are a few places in gdb where code prints an error message >> >>with a type included in it. The only way for these functions to >> >>print a type is with type_print(), which takes a ui_file stream to >> >>print its output to. This means they either have to send the output >> >>to gdb_stderr, or build up a fake memory ui_file and retrieve the >> >>contents. >> >> >> >>This patch adds a type_sprint() which does the latter and returns the >> >>xmalloc()'ed string. > >> >> Good interface choice! Just some tweaks. >> >> sprint makes me think of the nasty sprintf family, which this is >> definitly not. So .. suggest calling it something like type_xstrdup: >> x-> xmalloc family; strdup -> allocate a string duplicate (like >> ui_file_xstrdup, but yes pushing it a bit). The alternative would be >> type_xasprint (&string, ...) but I think that is getting ugly :-) > > > How about type_asprint? I really don't think that the x is necessary, > but the a would be a convenient reminder. GDB should use neither sprint* nor asprint*. type_sprint or type_asprint would confuse this. The xasprint* family all have the signature: ...xasprint* (char **buf, ....) which doesn't apply here. >> The old error message should never have included a period ("."), might >> as well remove it while tweaking the code. > > > Didn't we settle on full sentence error messages the last time this > came up? For the moment, it's a full sentence, with a leading upper case letter but no trailing period :-) The period doesn't make much sence to a GUI. The ARI is looking for this. Andrew