Re: [RFC] Trivialize objc-lang.c FETCH_ARGUMENT

Andrew Cagney
2003-04-25T02:07:22Z

> Well, I thought I'd at least try to see if this patch would be ok. Here I replace the arcitecture dependant FETCH_ARGUMENT with a trivial implementation that does nothing. This would allow objc-lang.o to be linked into gdb and I commit most or all of the remaining Objective-C patches. Then I could work on fixing FETCH_ARGUMENT at my leasure...
>
>
>
> 2003-04-21 Adam Fedor <fedor@gnu.org>
>
> * objc-lang.c (FETCH_ARGUMENT, CONVERT_FUNCPTR): Redefine to return
> a trivial value and remove architecture dependant compilation.
> Temporary until they get put in the gdbarch vector.

Change it to call internal error, otherwize approved.

Andrew

> Index: objc-lang.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/objc-lang.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 objc-lang.c
> --- objc-lang.c 21 Apr 2003 16:48:39 -0000 1.18
> +++ objc-lang.c 22 Apr 2003 03:46:00 -0000
> @@ -1752,6 +1752,17 @@ _initialize_objc_language (void)
> add_com_alias ("po", "print-object", class_vars, 1);
> }
>
> +#if 1
> +/* Disable these functions until we put them in the gdbarch vector. */
> +static unsigned long FETCH_ARGUMENT (int i)
> +{
> + return 0;
> +}
> +static CORE_ADDR CONVERT_FUNCPTR (CORE_ADDR pc)
> +{
> + return pc;
> +}
> +#else
> #if defined (__powerpc__) || defined (__ppc__)
> static unsigned long FETCH_ARGUMENT (int i)
> {
> @@ -1790,6 +1801,7 @@ static CORE_ADDR CONVERT_FUNCPTR (CORE_A
> {
> return pc;
> }
> +#endif
> #endif
>
> static void