From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2065 invoked by alias); 11 Apr 2003 05:18:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2050 invoked from network); 11 Apr 2003 05:18:25 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Apr 2003 05:18:25 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h3B5IPe26998 for ; Fri, 11 Apr 2003 01:18:25 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3B5IOW29112; Fri, 11 Apr 2003 01:18:24 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h3B5IN512427; Thu, 10 Apr 2003 22:18:23 -0700 Message-ID: <3E96501F.95D6F7DC@redhat.com> Date: Fri, 11 Apr 2003 05:18:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA/TESTSUITE] build schedlock.c on 64-bit platforms References: <16019.15635.929065.664152@localhost.redhat.com> <20030409131329.GA4525@nevyn.them.org> <16021.31692.763468.4182@localhost.redhat.com> <20030410141953.GA10379@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00225.txt.bz2 Daniel Jacobowitz wrote: > > On Thu, Apr 10, 2003 at 10:12:28AM -0400, Elena Zannoni wrote: > > Daniel Jacobowitz writes: > > > On Tue, Apr 08, 2003 at 05:20:19PM -0400, Elena Zannoni wrote: > > > > > > > > I was getting warnings when compiling the test on 64-bit because of the casts. > > > > > > > > > > > > Sigh, I was just sloppy writing this one. Does it work if you pass > > > &args[i] instead of messing with my_number? That's a little more > > > portable. > > > > > > > Ok, how about this? But now get_current_thread in schedlock.exp > > doesn't work, because the output has changed. I am not sure I > > understand what it should be doing now. There is no way to get the > > thread number from the backtraces. > > Oh, you're right - sorry for the wild goose chase. I think your > previous patch with the cast to long is OK then. The test isn't > terribly portable but it should be portable enough for our use. Why don't you just declare 'i' a long and be done with it? > > Index: schedlock.c > > =================================================================== > > RCS file: /cvs/uberbaum/gdb/testsuite/gdb.threads/schedlock.c,v > > retrieving revision 1.2 > > diff -u -p -r1.2 schedlock.c > > --- schedlock.c 23 Oct 2002 03:22:56 -0000 1.2 > > +++ schedlock.c 10 Apr 2003 14:00:41 -0000 > > @@ -18,19 +18,21 @@ int main() { > > for (i = 0; i < NUM; i++) > > { > > args[i] = 1; > > - res = pthread_create(&threads[i], NULL, thread_function, (void *)i); > > + res = pthread_create(&threads[i], > > + NULL, > > + thread_function, > > + (void *) &args[i]); > > } > > > > /* schedlock.exp: last thread start. */ > > args[i] = 1; > > - thread_function ((void *) i); > > + thread_function ((void *) &args[i]); > > > > exit(EXIT_SUCCESS); > > } > > > > void *thread_function(void *arg) { > > - int my_number = (int) arg; > > - int *myp = &args[my_number]; > > + int *myp = (int *)arg; > > > > /* Don't run forever. Run just short of it :) */ > > while (*myp > 0) > > > > > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer