From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11599 invoked by alias); 5 Apr 2003 15:30:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11592 invoked from network); 5 Apr 2003 15:30:57 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 5 Apr 2003 15:30:57 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 59AE62B23 for ; Sat, 5 Apr 2003 10:30:52 -0500 (EST) Message-ID: <3E8EF6AC.30803@redhat.com> Date: Sat, 05 Apr 2003 15:30:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [commit] Delete EXTRA_FRAME_INFO from .c code Content-Type: multipart/mixed; boundary="------------040102070007080706070407" X-SW-Source: 2003-04/txt/msg00081.txt.bz2 This is a multi-part message in MIME format. --------------040102070007080706070407 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 172 Hello, As best I can tell the SPARC definition of EXTRA_FRAME_INFO is the same as the HP/PA - it isn't actually used. I've deleted it by committing the attached, Andrew --------------040102070007080706070407 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 4731 2003-04-05 Andrew Cagney * config/sparc/tm-sparc.h (EXTRA_FRAME_INFO): Delete. * frame.h: Delete #ifdef EXTRA_FRAME_INFO code. Index: frame.h =================================================================== RCS file: /cvs/src/src/gdb/frame.h,v retrieving revision 1.80 diff -u -r1.80 frame.h --- frame.h 1 Apr 2003 19:26:52 -0000 1.80 +++ frame.h 5 Apr 2003 15:27:19 -0000 @@ -315,7 +315,7 @@ /* Describe the saved registers of a frame. */ -#if defined (EXTRA_FRAME_INFO) || defined (FRAME_FIND_SAVED_REGS) +#if defined (FRAME_FIND_SAVED_REGS) /* XXXX - deprecated */ struct frame_saved_regs { @@ -378,13 +378,6 @@ /* Allocated by frame_saved_regs_zalloc () which is called / initialized by DEPRECATED_FRAME_INIT_SAVED_REGS(). */ CORE_ADDR *saved_regs; /*NUM_REGS + NUM_PSEUDO_REGS*/ - -#ifdef EXTRA_FRAME_INFO - /* XXXX - deprecated */ - /* Anything extra for this structure that may have been defined - in the machine dependent files. */ - EXTRA_FRAME_INFO -#endif /* Anything extra for this structure that may have been defined in the machine dependent files. */ Index: config/sparc/tm-sparc.h =================================================================== RCS file: /cvs/src/src/gdb/config/sparc/tm-sparc.h,v retrieving revision 1.43 diff -u -r1.43 tm-sparc.h --- config/sparc/tm-sparc.h 26 Mar 2003 22:39:53 -0000 1.43 +++ config/sparc/tm-sparc.h 5 Apr 2003 15:27:20 -0000 @@ -406,53 +406,6 @@ /* DEPRECATED_FRAME_CHAIN takes a frame's nominal address and produces the frame's chain-pointer. */ -/* In the case of the Sun 4, the frame-chain's nominal address - is held in the frame pointer register. - - On the Sun4, the frame (in %fp) is %sp for the previous frame. - From the previous frame's %sp, we can find the previous frame's - %fp: it is in the save area just above the previous frame's %sp. - - If we are setting up an arbitrary frame, we'll need to know where - it ends. Hence the following. This part of the frame cache - structure should be checked before it is assumed that this frame's - bottom is in the stack pointer. - - If there isn't a frame below this one, the bottom of this frame is - in the stack pointer. - - If there is a frame below this one, and the frame pointers are - identical, it's a leaf frame and the bottoms are the same also. - - Otherwise the bottom of this frame is the top of the next frame. - - The bottom field is misnamed, since it might imply that memory from - bottom to frame contains this frame. That need not be true if - stack frames are allocated in different segments (e.g. some on a - stack, some on a heap in the data segment). - - GCC 2.6 and later can generate ``flat register window'' code that - makes frames by explicitly saving those registers that need to be - saved. %i7 is used as the frame pointer, and the frame is laid out - so that flat and non-flat calls can be intermixed freely within a - program. Unfortunately for GDB, this means it must detect and - record the flatness of frames. - - Since the prologue in a flat frame also tells us where fp and pc - have been stashed (the frame is of variable size, so their location - is not fixed), it's convenient to record them in the frame info. */ - -#define EXTRA_FRAME_INFO \ - CORE_ADDR bottom; \ - int in_prologue; \ - int flat; \ - /* Following fields only relevant for flat frames. */ \ - CORE_ADDR pc_addr; \ - CORE_ADDR fp_addr; \ - /* Add this to ->frame to get the value of the stack pointer at the */ \ - /* time of the register saves. */ \ - int sp_offset; - /* We need to override DEPRECATED_GET_SAVED_REGISTER so that we can deal with the way outs change into ins in different frames. */ Index: testsuite/gdb.base/break.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v retrieving revision 1.15 diff -u -r1.15 break.exp --- testsuite/gdb.base/break.exp 4 Apr 2003 20:03:46 -0000 1.15 +++ testsuite/gdb.base/break.exp 5 Apr 2003 15:27:20 -0000 @@ -914,8 +914,8 @@ -re "Breakpoint $decimal, $hex in marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" { pass "run until breakpoint set at small function, optimized file" } - # marker4() is defined at line 46 when compiled with -DPROTOTYPES -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" { + # marker4() is defined at line 46 when compiled with -DPROTOTYPES pass "run until breakpoint set at small function, optimized file" } -re ".*$gdb_prompt " { --------------040102070007080706070407--