From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5900 invoked by alias); 2 Apr 2003 21:53:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5893 invoked from network); 2 Apr 2003 21:53:50 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 2 Apr 2003 21:53:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7B9FE2B23; Wed, 2 Apr 2003 16:53:49 -0500 (EST) Message-ID: <3E8B5BED.7040100@redhat.com> Date: Wed, 02 Apr 2003 21:53:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch rfc] Add the frame's type to the unwinder References: <3E8B5905.1000704@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00046.txt.bz2 > While the above is true for new code, old code continues to use the same confused combination of frame_type_from_pc(), frame_unwind_find_by_pc(), deprecated_set_frame_type(), and legacy_get_prev_frame(). A legacy frame's type is initialized to UNKNOWN_FRAME, and then zero or more of those functions will override it. get_frame_type() mapping an UNKNOWN_FRAME onto a NORMAL_FRAME. My apologies to: DEPRECATED_INIT_EXTRA_FRAME_INFO DEPRECATED_INIT_FRAME_PC DEPRECATED_INIT_FRAME_PC_FIRST DEPRECATED_FRAME_INIT_SAVED_REGS which also manage to modify the type and should have been mentioned. Anyway, the new frame code does not have this problem. Andrew