From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12416 invoked by alias); 20 Mar 2003 21:27:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12409 invoked from network); 20 Mar 2003 21:27:06 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 20 Mar 2003 21:27:06 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7977D2B11; Thu, 20 Mar 2003 16:27:02 -0500 (EST) Message-ID: <3E7A3226.9040904@redhat.com> Date: Thu, 20 Mar 2003 21:27:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Adam Fedor , Daniel Jacobowitz Cc: GDB Patches Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5] References: <3E16093D.3070907@doc.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00436.txt.bz2 Daniel, Would it be possible to make the cplus_demangle() method part of the language vector? That way code like the patch below could be reduced to: /* Return demangled language symbol, or NULL. */ language_demangle (current_language, arg); This would in turn allow Adam to just add an equivalent objc_demangle() method to the objc language vector, and hence eliminate the need to always link in objc-lang.c. Andrew > RCS file: /cvs/src/src/gdb/maint.c,v > retrieving revision 1.30 > diff -u -p -r1.30 maint.c > --- maint.c 24 Dec 2002 03:57:58 -0000 1.30 > +++ maint.c 3 Jan 2003 03:06:25 -0000 > @@ -35,6 +35,7 @@ > #include "symfile.h" > #include "objfiles.h" > #include "value.h" > +#include "objc-lang.h" > > #include "cli/cli-decode.h" > > @@ -154,9 +155,8 @@ maintenance_demangle (char *args, int fr > switch (current_language->la_language) > { > case language_objc: > - /* Commented out until ObjC handling is enabled. */ > - /* demangled = objc_demangle (args); */ > - /* break; */ > + demangled = objc_demangle (args); > + break; > case language_cplus: > default: > demangled = cplus_demangle (args, DMGL_ANSI | DMGL_PARAMS);