From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13730 invoked by alias); 18 Mar 2003 15:50:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13644 invoked from network); 18 Mar 2003 15:50:51 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 18 Mar 2003 15:50:51 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 29AFF2B11; Tue, 18 Mar 2003 10:50:47 -0500 (EST) Message-ID: <3E774057.50209@redhat.com> Date: Tue, 18 Mar 2003 15:50:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add observer notification in normal_stop References: <20030318014944.GJ16507@gnat.com> <20030318015112.GK16507@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00396.txt.bz2 > [sigh, once more, with the patch this time...] Welcome to my world. > Hello, > > I am currently writing a regression test for observer.c, which will live > in testsuite/gdb.gdb. It's using a mechanism similar to xfullpath.exp. > But in order for the test to function, observer.o needs to be linked in. > This wasn't the case up to now, because there is currently no code using > it. > > This patch is adding a call to observer_notify_normal_stop() inside > normal_stop. This notification will be useful later, when the latest > version of ada-task.c (from ACT's repository, accessible from > libre.act-europe.fr BTW) is contributed. In the meantime, the overhead > is really minimal and it allows us to test observer.c by debugging gdb. > > 2003-03-17 J. Brobecker > > * infrun.c (observer.h): Add #include. > (normal_stop): Add call to observer_notify_normal_stop. > * Makefile.in (infrun.o): Add dependency on observer.h. > > Ok to apply? I think down the end, next to the annotate_stop() call, would be better. I'm assuming that the secret agenda is to replace all annotate_xxx() and xxx_hook() calls with a equivalent observer_notify_xxx() call. Hence, adding an observer_xxx() call where ever either of the former appears should be pretty obvious and largely mechanical. An orthogonal task is rationalizing some of those events and/or their call site. For instance, merging registers changed and memory changed into a single observer_notify_target_changed(). Andrew