From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21747 invoked by alias); 18 Mar 2003 15:38:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21660 invoked from network); 18 Mar 2003 15:38:44 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 18 Mar 2003 15:38:44 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D5DFD2B11; Tue, 18 Mar 2003 10:38:39 -0500 (EST) Message-ID: <3E773D7F.2010003@redhat.com> Date: Tue, 18 Mar 2003 15:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add some code in observer.c to allow unit-testing References: <20030318020905.GL16507@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00395.txt.bz2 > Hello again, > > Following a small discussion in gdb@, I have written a small regression > test for observer.c. > > http://sources.redhat.com/ml/gdb/2003-03/msg00147.html > > The test is done by doing inferior function calls to the normal_stop > observer routines. The sticky point is that the attach routine needs > to be provided with a function pointer (callback). This patch adds > 3 static counters and 3 static functions that simply increment these > counters. These functions will be provided to the attach routine during > the test (See upcoming testsuite patch for more details) > > 2003-03-17 J. Brobecker > > * observer.c (observer_test_first_observer): New static variable. > (observer_test_second_observer): Likewise. > (observer_test_third_observer): Likewise. > (observer_test_first_notification_function): New static function. > (observer_test_second_notification_function): Likewise. > (observer_test_third_notification_function): Likewise. > > Ok to apply? Long term, it's going to run into -Wunused-function. Suggest adding a disclaimer pointing out this limitation :-) Otherwize (for want of any beter idea :-), ok. Andrew > Index: observer.c > =================================================================== > RCS file: /cvs/src/src/gdb/observer.c,v > retrieving revision 1.2 > diff -c -3 -p -r1.2 observer.c > *** observer.c 28 Feb 2003 07:19:32 -0000 1.2 > --- observer.c 18 Mar 2003 01:51:47 -0000 > *************** observer_notify_normal_stop (void) > *** 190,192 **** > --- 190,218 ---- > { > generic_observer_notify (normal_stop_subject, NULL); > } > + > + /* The following code is only used to unit-test the observers from > + our testsuite. DO NOT USE IT within observer.c! */ > + > + static int observer_test_first_observer = 0; > + static int observer_test_second_observer = 0; > + static int observer_test_third_observer = 0; > + > + static void > + observer_test_first_notification_function (void) > + { > + observer_test_first_observer++; > + } > + > + static void > + observer_test_second_notification_function (void) > + { > + observer_test_second_observer++; > + } > + > + static void > + observer_test_third_notification_function (void) > + { > + observer_test_third_observer++; > + } > +