From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32452 invoked by alias); 13 Mar 2003 00:05:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32423 invoked from network); 13 Mar 2003 00:05:26 -0000 Received: from unknown (HELO localhost.redhat.com) (66.187.230.200) by sources.redhat.com with SMTP; 13 Mar 2003 00:05:26 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 47B4B2B11; Wed, 12 Mar 2003 19:05:26 -0500 (EST) Message-ID: <3E6FCB46.2090407@redhat.com> Date: Thu, 13 Mar 2003 00:05:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch wip] Delete get_saved_register() References: <3E6F82D1.8050805@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00295.txt.bz2 > Hello, > > The attached deletes the function get_saved_register(). It's been superseeded by frame_register() et.al. > > Right now, this patch causes a (major) regression. The sequence: > > $ gdb program > (gdb) print $pc > > gets an internal error. An examination of a backtrace reveals that the code was using `deprecated_selected_frame' and that was NULL. Before committing the attached, I'm going to have to relace a few `deprecated_selected_frame's with `get_selected_frame()' (the latter throws an error if there really is no frame). > > So at this stage, this patch is largely a heads up. Once I've eliminated all the regressions, I'll commit the attached. FYI, I've fixed the failures. I'll commit in a few days. Andrew > > 2003-03-12 Andrew Cagney > > * frame.c (get_saved_register): Delete function. > * xstormy16-tdep.c: Update comment. > * regcache.h: Update comments. > * sparc-tdep.c (sparc_init_extra_frame_info): Instead of > get_saved_register and extract_address, use > frame_read_unsigned_register. > (sparc_frame_saved_pc): Ditto. > (sparc_get_saved_register): Instead of get_saved_register, use > frame_register. > (sparc_pop_frame): Ditto. > * frame.h (get_saved_register): Delete declaration. > * findvar.c: Update comments. > (value_of_register): Call frame_register instead of > get_saved_register. > (value_from_register): Ditto. > * config/sparc/tm-sparc.h: Update comment. > * breakpoint.c: Update comment. > > Index: doc/ChangeLog > 2003-03-12 Andrew Cagney > > * gdbint.texinfo (Target Architecture Definition): Delete > references to get_saved_register. >