Re: [rfa] Add e500 function call support to PPC

Kevin Buettner
2003-03-10T17:54:13Z

On Mar 10, 10:11am, Andrew Cagney wrote:

> > This construct bothers me. If it occurred only once, it might not
> > bother me so much, but (arch_info->mach != bfd_mach_ppc_e500) appears
> > far too often in the code for me to be comfortable with it. Suppose
> > we have another core with a similar property (of passing everything
> > in GPRs). If this happens, we'll end up with a proliferation of
> > additional checks for all of these different cores and things will
> > become quite unreadable. Please introduce a predicate into which
> > we can put this test and perhaps others as they arise. Then, only
> > the predicate will need to be modified.
>
> Such as:
>
> if (.....
> && tdep->ppc_fp0_regnum >= 0)
>
> ?

If the ppc's tdep struct had such a member that would probably be okay.

Kevin