From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-tdep.c: Add dwarf/dwarf2 regnum mapping functions
Date: Fri, 07 Mar 2003 18:52:00 -0000 [thread overview]
Message-ID: <3E68EA63.10401@redhat.com> (raw)
In-Reply-To: <1030307175146.ZM16168@localhost.localdomain>
> Okay?
>
>>
>> Yes, just make it a little bit more robust. The i386 does this:
>>
>> /* This will hopefully provoke a warning. */
>> return NUM_REGS + NUM_PSEUDO_REGS;
>>
>> when it doesn't know what to do with a register.
>
>
> Rather than hoping that returning an out of range register number will
> provoke a warning (at some indeterminate point in the future),
> wouldn't it be better to call complaint() directly? Or, alternatively,
> define a return value (e.g. -1) which callers of *_REG_TO_REGNUM would
> then check so that an appropriate complaint could be registered?
True. In the mean time, these new methods might as well be consistent
with the other existing reg_to_regnum methods (from memory, it does
eventually provoke a warning).
Andrew
next prev parent reply other threads:[~2003-03-07 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-04 21:17 Kevin Buettner
2003-03-07 17:04 ` Andrew Cagney
2003-03-07 17:52 ` Kevin Buettner
2003-03-07 18:52 ` Andrew Cagney [this message]
2003-03-11 21:22 ` Kevin Buettner
2003-03-11 22:06 ` Andrew Cagney
2003-03-07 19:13 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2003-03-31 23:11 [RFA] MIPS: Add mappings for HI and LO registers Kevin Buettner
2003-04-02 3:36 ` Andrew Cagney
2003-03-04 17:24 [RFA] mips-tdep.c: Fix printing of floats in "info all-registers" Kevin Buettner
2003-03-04 18:01 ` Andrew Cagney
2002-12-17 10:35 [patch/rfc] Add get_*() to rs6000-tdep.c Andrew Cagney
[not found] ` <ac131313@redhat.com>
2002-12-17 14:13 ` Kevin Buettner
2002-12-18 7:37 ` Andrew Cagney
2003-03-11 23:16 ` [RFA] mips-tdep.c: Add dwarf/dwarf2 regnum mapping functions Kevin Buettner
2003-03-11 23:18 ` [RFA] mips-tdep.c: Fix printing of floats in "info all-registers" Kevin Buettner
2003-04-02 5:13 ` [RFA] MIPS: Add mappings for HI and LO registers Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E68EA63.10401@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox