From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26535 invoked by alias); 7 Mar 2003 10:44:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26528 invoked from network); 7 Mar 2003 10:44:56 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by 172.16.49.205 with SMTP; 7 Mar 2003 10:44:56 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id A981359D34D; Fri, 7 Mar 2003 11:44:55 +0100 (CET) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id h27Ait420225; Fri, 7 Mar 2003 11:44:55 +0100 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3E687827.2050006@suse.cz> Date: Fri, 07 Mar 2003 10:44:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: GDB Patches Subject: Re: [RFA] Prologue detection on x86-64 References: <3E67D22C.3030908@suse.cz> <20030306231007.GA9627@nevyn.them.org> <3E67D66F.5070005@suse.cz> <20030306232209.GA10007@nevyn.them.org> In-Reply-To: <20030306232209.GA10007@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00152.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Mar 07, 2003 at 12:14:55AM +0100, Michal Ludvig wrote: > >>Daniel Jacobowitz wrote: >> >>>On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote: >>> >>>>+/* We will handle only functions beginning with: >>>>+ 55 pushq %rbp >>>>+ 48 89 e5 movq %rsp,%rbp */ >>> >>>Period and two spaces, please. >> >>Period after %rbp? It wouldn't be an assembler anymore :-( >>How about two spaces and no period instead? (compromise :-) > > What I usually do in this case is make up a sentence to go before the > period :P No joking. Something like: > /* We will handle only functions beginning with > 55 pushq %rbp > 48 89 e5 movq %rsp, %rbp > Any function that doesn't start with this sequence > will be assumed to have no prologue. */ OK, committed with this change and removed 'static' keyword. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * (+420) 296.545.373 * http://www.suse.cz