From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5047 invoked by alias); 6 Mar 2003 23:14:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5038 invoked from network); 6 Mar 2003 23:14:56 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by 172.16.49.205 with SMTP; 6 Mar 2003 23:14:56 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 02B6959D307; Fri, 7 Mar 2003 00:14:56 +0100 (CET) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id h26NEt406871; Fri, 7 Mar 2003 00:14:55 +0100 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3E67D66F.5070005@suse.cz> Date: Thu, 06 Mar 2003 23:14:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: GDB Patches Subject: Re: [RFA] Prologue detection on x86-64 References: <3E67D22C.3030908@suse.cz> <20030306231007.GA9627@nevyn.them.org> In-Reply-To: <20030306231007.GA9627@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00149.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote: >>+/* We will handle only functions beginning with: >>+ 55 pushq %rbp >>+ 48 89 e5 movq %rsp,%rbp */ > > Period and two spaces, please. Period after %rbp? It wouldn't be an assembler anymore :-( How about two spaces and no period instead? (compromise :-) >>+#define PROLOG_BUFSIZE 4 >>+static int >>+x86_64_function_has_prologue (CORE_ADDR pc) > >>+int x86_64_function_has_prologue (CORE_ADDR pc); > > > That's probably a warning. Static functions don't need to be > prototyped in the tdep.h file; this bit can just be omitted. Oops, sorry. Shouldn't be static, because it will be used in x86-64-linux-tdep.c, so I need a prototype in x86-64-tdep.h. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * (+420) 296.545.373 * http://www.suse.cz