From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28589 invoked by alias); 4 Mar 2003 18:01:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28579 invoked from network); 4 Mar 2003 18:01:51 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 4 Mar 2003 18:01:51 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E74B32A9C; Tue, 4 Mar 2003 13:01:49 -0500 (EST) Message-ID: <3E64EA0D.8070601@redhat.com> Date: Tue, 04 Mar 2003 18:01:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-tdep.c: Fix printing of floats in "info all-registers" References: <1030304172439.ZM23900@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00102.txt.bz2 > When doing "info all-registers" on 64-bit mips, floating point values are > not being displayed correctly. OTOH, the output of "info float" is correct. > > Thanks to Chris Demetriou for bringing this problem to my attention. > > Okay? Yes. > * mips-tdep.c (do_fp_register_row): Fix typo which caused a double > type to be used when attempting to unpack a float. > > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.168 > diff -u -p -r1.168 mips-tdep.c > --- mips-tdep.c 3 Mar 2003 20:50:19 -0000 1.168 > +++ mips-tdep.c 4 Mar 2003 17:16:24 -0000 > @@ -4150,7 +4150,7 @@ do_fp_register_row (int regnum) > { > /* Eight byte registers: print each one as float AND as double. */ > mips_read_fp_register_single (regnum, raw_buffer); > - flt1 = unpack_double (mips_double_register_type (), raw_buffer, &inv1); > + flt1 = unpack_double (mips_float_register_type (), raw_buffer, &inv1); > > mips_read_fp_register_double (regnum, raw_buffer); > doub = unpack_double (mips_double_register_type (), raw_buffer, &inv3); >